From 7cedbe9f1c221d969b1e98fc3024ed6c4e78e9d4 Mon Sep 17 00:00:00 2001 From: Claude Fable 5 Date: Fri, 7 Aug 2026 18:13:26 +0000 Subject: [PATCH] test(objectql): drop the dangling debug helper in save-meta-response-conformance MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `LOG` helper declared at :119 referenced two names that exist nowhere in the file: `appendFileSync` (never imported from `node:fs`) and `OUT` (never defined). `LOG` itself was never called, so it never threw at runtime — it was dead debug scaffolding left behind when its import and constant were dropped. A debug helper that looks usable but raises `ReferenceError` the moment someone uncomments a call is worse than no helper at all. Also passes the required `packageId` argument to `registry.registerObject` at :115, which was called with one argument against a `(schema, packageId, ...)` signature. Both defects are invisible to every gate because `packages/objectql/tsconfig.json` excludes `**/*.test.ts` (#4311), so `tsc` never reads this file; vitest does not type-check and ESLint does no cross-symbol resolution. Fixes #5924 Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_019Q7oc7ASjh8yxyS3Yz78We --- packages/objectql/src/save-meta-response-conformance.test.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/objectql/src/save-meta-response-conformance.test.ts b/packages/objectql/src/save-meta-response-conformance.test.ts index e0b6611f6e..9fcc771197 100644 --- a/packages/objectql/src/save-meta-response-conformance.test.ts +++ b/packages/objectql/src/save-meta-response-conformance.test.ts @@ -112,12 +112,10 @@ async function makeProtocol() { const { driver } = makeMemoryDriver(); engine.registerDriver(driver, true); await engine.init(); - engine.registry.registerObject(sysMetadataObject as any); + engine.registry.registerObject(sysMetadataObject as any, 'test-package'); return new ObjectStackProtocolImplementation(engine); } -const LOG = (...a: any[]) => appendFileSync(OUT, a.join(' ') + '\n'); - const viewBody = (label: string) => ({ name: 'cases', type: 'grid', label, columns: ['id'] }); /** Keys the producer emitted that the schema refused to carry through. */