Skip to content

objectui: five more hardcoded English chrome strings found in #5430's sweep radius (tab-count N items, Resize drawer, Open as full page, Record Detail, CommentThread's reaction tooltip) #5506

Description

@yinlianghui

Swept while implementing objectstack#5430. Same class as that issue — accessible names and visible defaults still hardcoded in English — but outside its four-string scope, so filed rather than fixed there.

String Site Kind
{count} items packages/components/src/renderers/layout/containers.tsx:573 — the page:tabs count badge's aria-label, built by template literal icon/number-only, so the label IS the badge to a screen reader; also English-pluralized by construction
Resize drawer packages/components/src/custom/navigation-overlay.tsx:357 — the drag handle's aria-label on role="separator" handle has no visible label
Open as full page packages/components/src/custom/navigation-overlay.tsx:279expandLabel prop default feeds both aria-label and title of an icon-only button; overridable by callers, but the default is what ships
Record Detail packages/components/src/custom/navigation-overlay.tsx:282resolvedTitle = title || 'Record Detail' visible overlay heading, not just an a11y name
1 reaction / {n} reactions packages/collaboration/src/CommentThread.tsx:520 — reaction tooltip, userIds.length === 1 ? '1 reaction' : ... English pluralization built in, exactly the shape #5430 replaced in ReactionPicker

Also in the same file, three copies of the prose Record detail overlay for {resolvedTitle}. (navigation-overlay.tsx:377, :442, :526) feed SheetDescription/DialogDescription.

Notes for whoever picks this up

The Record Detail default is the only visible string here; the rest are accessible names and hover tooltips.

Generated by Claude Code

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions