You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
objectui: five more hardcoded English chrome strings found in #5430's sweep radius (tab-count N items, Resize drawer, Open as full page, Record Detail, CommentThread's reaction tooltip) #5506
Swept while implementing objectstack#5430. Same class as that issue — accessible names and visible defaults still hardcoded in English — but outside its four-string scope, so filed rather than fixed there.
String
Site
Kind
{count} items
packages/components/src/renderers/layout/containers.tsx:573 — the page:tabs count badge's aria-label, built by template literal
icon/number-only, so the label IS the badge to a screen reader; also English-pluralized by construction
Resize drawer
packages/components/src/custom/navigation-overlay.tsx:357 — the drag handle's aria-label on role="separator"
English pluralization built in, exactly the shape #5430 replaced in ReactionPicker
Also in the same file, three copies of the prose Record detail overlay for {resolvedTitle}. (navigation-overlay.tsx:377, :442, :526) feed SheetDescription/DialogDescription.
Swept while implementing objectstack#5430. Same class as that issue — accessible names and visible defaults still hardcoded in English — but outside its four-string scope, so filed rather than fixed there.
{count} itemspackages/components/src/renderers/layout/containers.tsx:573— thepage:tabscount badge'saria-label, built by template literalResize drawerpackages/components/src/custom/navigation-overlay.tsx:357— the drag handle'saria-labelonrole="separator"Open as full pagepackages/components/src/custom/navigation-overlay.tsx:279—expandLabelprop defaultaria-labelandtitleof an icon-only button; overridable by callers, but the default is what shipsRecord Detailpackages/components/src/custom/navigation-overlay.tsx:282—resolvedTitle = title || 'Record Detail'1 reaction/{n} reactionspackages/collaboration/src/CommentThread.tsx:520— reaction tooltip,userIds.length === 1 ? '1 reaction' : ...ReactionPickerAlso in the same file, three copies of the prose
Record detail overlay for {resolvedTitle}.(navigation-overlay.tsx:377,:442,:526) feedSheetDescription/DialogDescription.Notes for whoever picks this up
CommentThreadone must use the repo's two-key plural convention (detail.reactionCount/detail.reactionCountOne, added to all ten packs by objectui: remaining untranslated console-chrome accessible names (Page header actions,Emoji picker, the reaction-count label,Close/Close panelin the nav overlay) #5430), not an i18next_one/_otherpair —all-locales-key-parityrejects the suffix scheme because zh/ja/ko have no separate singular form. The two keys already exist and interpolate{{emoji}}and{{count}};CommentThread's tooltip has no emoji, so it likely needs its own pair rather than reuse.{count} itemshas the same pluralization problem and needs the same two-key treatment.packages/collaborationis a different package from objectui: remaining untranslated console-chrome accessible names (Page header actions,Emoji picker, the reaction-count label,Close/Close panelin the nav overlay) #5430's three; check its i18n wiring before assuminguseSafeTranslateis available.e2e/live/inline-edit-polish-2572.spec.ts:61addresses the header toolbar by its English accessible name, andpackages/plugin-view/src/__tests__/ObjectView.test.tsxaddresses the overlay close bygetByLabelText('Close panel'). Both still pass after objectui: remaining untranslated console-chrome accessible names (Page header actions,Emoji picker, the reaction-count label,Close/Close panelin the nav overlay) #5430 (no provider means the English fallback resolves), but a locale-parameterized run would need updating.The
Record Detaildefault is the only visible string here; the rest are accessible names and hover tooltips.Generated by Claude Code