Swept while implementing objectstack#5407 item 2, which enumerates four strings (More actions, Add reaction, Clear, Close). These are the neighbours the sweep turned up that #5407 does not name, so they are filed here rather than smuggled into that PR.
All are icon-only controls, so the hardcoded literal IS the control's name to a screen reader and to a hover tooltip.
| String |
Site |
Page header actions |
packages/components/src/renderers/layout/containers.tsx — the role="toolbar" accessible name, ~8 lines above the More actions trigger #5407 fixes |
Emoji picker |
packages/plugin-detail/src/ReactionPicker.tsx — the role="listbox" popup the (now translated) add button opens |
{emoji} {count} reaction(s) |
same file — the per-reaction chip's label, with English pluralization built in (reaction${count !== 1 ? 's' : ''}) |
Close + Close panel |
packages/components/src/custom/navigation-overlay.tsx lines 391-392 and 476 |
The pluralized one needs a shape decision, not just a key
This repo does not use i18next plural suffixes — it uses an explicit two-key scheme (lookup.recordCount / lookup.recordCountOne, detail.relatedRecords / detail.relatedRecordOne). A _one / _other pair would also break all-locales-key-parity, since zh/ja legitimately have no _one form and the guard demands identical key sets. So the reaction-count label should follow the existing two-key convention, not introduce a third.
Not filed here
Clear and Close as #5407 reports them (untranslated in every locale) could not be reproduced in the console chrome a CRM sweep would touch — see the objectstack#5407 dev report for the enumeration of every Clear/Close site and which resolver each one already goes through.
Swept while implementing objectstack#5407 item 2, which enumerates four strings (
More actions,Add reaction,Clear,Close). These are the neighbours the sweep turned up that #5407 does not name, so they are filed here rather than smuggled into that PR.All are icon-only controls, so the hardcoded literal IS the control's name to a screen reader and to a hover tooltip.
Page header actionspackages/components/src/renderers/layout/containers.tsx— therole="toolbar"accessible name, ~8 lines above theMore actionstrigger #5407 fixesEmoji pickerpackages/plugin-detail/src/ReactionPicker.tsx— therole="listbox"popup the (now translated) add button opens{emoji} {count} reaction(s)reaction${count !== 1 ? 's' : ''})Close+Close panelpackages/components/src/custom/navigation-overlay.tsxlines 391-392 and 476The pluralized one needs a shape decision, not just a key
This repo does not use i18next plural suffixes — it uses an explicit two-key scheme (
lookup.recordCount/lookup.recordCountOne,detail.relatedRecords/detail.relatedRecordOne). A_one/_otherpair would also breakall-locales-key-parity, since zh/ja legitimately have no_oneform and the guard demands identical key sets. So the reaction-count label should follow the existing two-key convention, not introduce a third.Not filed here
ClearandCloseas #5407 reports them (untranslated in every locale) could not be reproduced in the console chrome a CRM sweep would touch — see the objectstack#5407 dev report for the enumeration of everyClear/Closesite and which resolver each one already goes through.