Commit 9915480
committed
fix(metadata-protocol): realign the SysMetadataEngine test doubles' transaction signature with the contract (#5696)
CI's `TypeScript Type Check` went red where a scoped `pnpm --filter …
typecheck` could not: @objectstack/metadata-protocol has no `typecheck`
script, so its errors are only ever seen by the DEBT ledger's `--re-measure`,
which reported 63 -> 70 (+7).
All seven were one shape. Six test doubles stand in for `SysMetadataEngine`,
whose `transaction?` member is typed FROM the contract
(`IObjectQLEngine['transaction']`), and each declared its callback as
`(ctx: any) => Promise<T>` — one parameter, from before the callback gained
its `info` argument. A double may be narrower than the producer; it may not
contradict it.
Each now declares `(ctx: any, info: { owned: boolean })` and passes
`{ owned: true }` at the call — the honest value, since every one of these
doubles OPENS the transaction it stands in for, which is exactly what
`ObjectQL.transaction` reports on its own open branch.
Re-measured: 63 raw errors, the frozen count, with zero transaction-related
errors remaining. `check-type-check-coverage --re-measure` reports no upward
drift. metadata-protocol: 49 files / 502 tests pass.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019Q7oc7ASjh8yxyS3Yz78We1 parent 718028b commit 9915480
6 files changed
Lines changed: 10 additions & 10 deletions
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
172 | | - | |
173 | | - | |
| 172 | + | |
| 173 | + | |
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
170 | | - | |
| 169 | + | |
| 170 | + | |
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
| 189 | + | |
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
| 161 | + | |
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
| 99 | + | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| |||
0 commit comments