Skip to content

Commit 3bfcecd

Browse files
committed
chore(qa,objectql): drop dogfood's unconsumed driver-memory devDep + de-reference driver-memory in one stub comment (#5829)
#5704 收口尾单(批次 2/3 已合入 PR #5797/#5806),两件留档尾项: 1. `packages/qa/dogfood` 的 `@objectstack/driver-memory` devDep:#5715(批次 0) 把 read-coercion 一致性测试的 memory 臂移除后,全包已零真实 import (`git grep -in memory -- packages/qa/dogfood` 只剩 README 的 "in-memory SQLite" 散文与 read-coercion-conformance.test.ts:9 记录移除原因的 注释)。摘除声明 + lockfile 随动(仅该一条 importer 链接)。 2. `protocol-batch-atomic.test.ts` 的 `makeSnapshotDriver()` 头注释把这个本地 手写 stub 说成「the same shape driver-memory uses」——packages/objectql 根本 不依赖 driver-memory,这类措辞正是 #5704 Phase 1 survey 里让 `grep -i memory` 虚高的来源。按 #5797 同款原则改写为指涉 stub 自身。 `protocol-data.test.ts:759` 经复核**原样保留**:那一句 「Mirror of #3948's rule for driver-memory: an unapplied filter must not look like a satisfied one」指的是真实 driver-memory 包里真实存在的不变量 (`filter-refusal.ts`、`memory-driver.ts:753/792/817`、 `memory-filter-ast-vocabulary.test.ts`),属于 #5797 已开的例外类 (描述真实驱动族行为的散文一律保留),不是把 stub 说成 driver-memory。 零行为变更。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WyvqvKMG6asi9aXjKE6xtx
1 parent 75f82f3 commit 3bfcecd

3 files changed

Lines changed: 3 additions & 7 deletions

File tree

packages/objectql/src/protocol-batch-atomic.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ import { ObjectStackProtocolImplementation } from '@objectstack/metadata-protoco
1818
import type { IObjectQLEngine } from '@objectstack/spec/contracts';
1919

2020
/**
21-
* A driver with real transaction semantics: `beginTransaction` snapshots every
22-
* table, `rollback` restores the snapshot wholesale, `commit` drops it — the
23-
* same shape `driver-memory` uses, small enough to assert against.
21+
* A stub driver with real transaction semantics: `beginTransaction` snapshots
22+
* every table, `rollback` restores the snapshot wholesale, `commit` drops it —
23+
* a genuine rollback, small enough to assert against.
2424
*/
2525
function makeSnapshotDriver() {
2626
const stores = new Map<string, Map<string, any>>();

packages/qa/dogfood/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
},
3535
"devDependencies": {
3636
"@objectstack/core": "workspace:*",
37-
"@objectstack/driver-memory": "workspace:*",
3837
"@objectstack/driver-sql": "workspace:*",
3938
"@objectstack/driver-sqlite-wasm": "workspace:*",
4039
"@types/node": "^26.1.2",

pnpm-lock.yaml

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)