Require win/loss reasons on close and surface win/loss analytics

[os-zhuang]

Batch-2 (business completeness) item from the 2026-08-02 review. Small scope, closes an existing loop.

Problem

crm_opportunity.win_reason / loss_reason / loss_details exist, and the loss_reason field comment even says "required when stage moves to closed_"* — but nothing enforces it (crm_case has exactly the pattern needed: resolution_required_for_closed). No report or dashboard widget consumes the fields either, so they are empty and invisible.

Scope

1. Enforce capture: requiredWhen conditional rules (v17, server-enforced — already available on the pinned protocol) or a cross_field validation — loss_reason required on closed_lost, win_reason on closed_won.
2. Analytics: win-rate metric (won / (won+lost)) by owner and by lead source; loss-reason breakdown widget; both feed from opportunity_metrics (add measures as needed).
3. i18n for any new labels in all 4 locales (the reason picklist values are among the 15 keys already missing in ja/es — see i18n: 205 warnings hidden by --skip-i18n; broken option keys and untranslated navigation #494).

Acceptance

• Closing an opportunity without the applicable reason is rejected server-side.
• Sales dashboard shows win rate and a loss-reason breakdown with seeded data.

[os-zhuang]

认领:PM 循环第 9 轮
会话:session_019SS7C5SXpniKeCApxgARyf
分支:claude/issue-593-win-loss-reasons
Worktree:hotcrm-issue-593

---

本轮唯一的 P0。正文的三条范围照做,但有一条必须自己量、不要照抄 issue 的措辞:

正文说"用 requiredWhen 条件规则(v17,服务端强制)或 cross_field 校验"。这个"或"字底下藏着本仓库这几轮反复踩的那一族坑——声明了不等于被强制。本轮已经量出五种不同的机制,各自的失败方式完全不同:对象脚本校验在谓词求值失败时静默跳过只留 WARN(#634 / objectstack#4649);共享规则根本不解释执行、而是编译成下推 SQL(#621);流程条件抛错但触发它的那次写入照样成功(#633);decision 节点的单数 config.condition 引擎从不读取(#650);流程变量声明了在运行时什么也不绑定(#651)。

所以第 1 条的验收不是"规则写上去了",而是:用真驱动 + 真写入路径复现一次——不带 loss_reason 把商机置为 closed_lost,写入必须被拒绝(不是记 WARN、不是 dry-run 说不行但写入放行——后面这个错配是已知的,见 objectstack#4633 / #4647)。两条路子哪条真的能挡住写入,就用哪条;两条都挡不住,就是又一处"声明 ≠ 强制",按发现报上来、不要硬凑。crm_case 的 resolution_required_for_closed 是正文点名的现成范式,先去读它、确认它今天真的在挡写入,再决定是不是照抄。

第 2 条分析面注意别复制 #614 的错:那次仪表盘把 150 万的季度配额显示成 7,940,000,根因是过滤器少了一半。胜率是个比值,分母写错不会报错、只会给出一个看起来合理的数——请给出一张表证明分子分母两半都是承重的(改任一半,数字都要变)。

第 3 条 i18n:本轮四个语言包文件归你独占,另外两件已被明确禁止触碰,你不必担心冲突。顺带确认一下 #494 里提到的那 15 个 ja/es 缺键中属于本次 picklist 的部分是不是也该一并补——如果超出范围就在报告里说明,不要默默扩。

**文件边界(本轮三件并行,严格分工):**你拥有 src/objects/opportunity.object.ts、报表/仪表盘、src/data/sales.seed.ts、以及全部 i18n 语言包。不要动 src/objects/account.object.ts / account.hook.ts / src/flows/lead-conversion.flow.ts(#626 拥有)、不要动 src/flows/demo-bootstrap.flow.ts / src/permissions/(#640 拥有)。

---

Generated by Claude Code