From ef25b1bf439517e17f2a383dfba41aaf4fab5d48 Mon Sep 17 00:00:00 2001 From: Omid Mirzaei Date: Fri, 18 Sep 2026 13:47:54 +0400 Subject: [PATCH 1/4] fail closed on unknown partner event schemas --- internal/domain/event.go | 14 ++++++++------ internal/ingest/validate.go | 3 +++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/internal/domain/event.go b/internal/domain/event.go index 5ae89e9..df67164 100644 --- a/internal/domain/event.go +++ b/internal/domain/event.go @@ -6,13 +6,15 @@ const ( EventDeposit = "deposit" EventBetPlaced = "bet_placed" EventSessionHeartbeat = "session_heartbeat" + EventSchemaV1 = 1 ) type Event struct { - OccurredAt time.Time `json:"occurred_at"` - EventID string `json:"event_id"` - TenantID string `json:"tenant_id"` - PlayerID string `json:"player_id"` - Type string `json:"type"` - Amount int64 `json:"amount,omitempty"` + OccurredAt time.Time `json:"occurred_at"` + EventID string `json:"event_id"` + TenantID string `json:"tenant_id"` + PlayerID string `json:"player_id"` + Type string `json:"type"` + Amount int64 `json:"amount,omitempty"` + SchemaVersion int `json:"schema_version,omitempty"` } diff --git a/internal/ingest/validate.go b/internal/ingest/validate.go index e4e97e9..08fd8cf 100644 --- a/internal/ingest/validate.go +++ b/internal/ingest/validate.go @@ -27,6 +27,9 @@ func ValidateEvent(evt domain.Event) error { return fmt.Errorf("amount must be positive for %s", evt.Type) } } + if evt.SchemaVersion != 0 && evt.SchemaVersion != domain.EventSchemaV1 { + return fmt.Errorf("unsupported schema_version %d", evt.SchemaVersion) + } return nil } From efe658ce74555ca0224fb63c0a089f6df1116ea9 Mon Sep 17 00:00:00 2001 From: Omid Mirzaei Date: Fri, 18 Sep 2026 13:48:02 +0400 Subject: [PATCH 2/4] reject schema v2 at ingest and keep v1 heartbeats --- internal/api/httpapi/schema_test.go | 107 ++++++++++++++++++++++++++++ internal/ingest/validate_test.go | 52 ++++++++++++++ 2 files changed, 159 insertions(+) create mode 100644 internal/api/httpapi/schema_test.go create mode 100644 internal/ingest/validate_test.go diff --git a/internal/api/httpapi/schema_test.go b/internal/api/httpapi/schema_test.go new file mode 100644 index 0000000..1929f33 --- /dev/null +++ b/internal/api/httpapi/schema_test.go @@ -0,0 +1,107 @@ +package httpapi_test + +import ( + "bytes" + "encoding/json" + "fmt" + "io" + "net/http" + "strings" + "testing" + "time" + + "github.com/o-mid/engagepulse/internal/domain" + "github.com/o-mid/engagepulse/internal/ingest" +) + +func TestIngestRejectsUnknownSchemaVersion(t *testing.T) { + st, srv := newSecurityTestServer(t) + defer st.Close() + defer srv.Close() + + suffix := fmt.Sprintf("%d", time.Now().UnixNano()) + evt := domain.Event{ + EventID: "schema-bad-" + suffix, + TenantID: "acme-casino", + PlayerID: "schema-player-" + suffix, + Type: domain.EventDeposit, + Amount: 50, + SchemaVersion: 2, + OccurredAt: time.Now().UTC(), + } + body, err := json.Marshal(evt) + if err != nil { + t.Fatalf("marshal: %v", err) + } + req, err := http.NewRequest(http.MethodPost, srv.URL+"/v1/events", bytes.NewReader(body)) + if err != nil { + t.Fatalf("request: %v", err) + } + req.Header.Set("Content-Type", "application/json") + req.Header.Set("X-Signature", ingest.Sign("hmac_acme_dev_secret", body)) + + resp, err := http.DefaultClient.Do(req) + if err != nil { + t.Fatalf("do: %v", err) + } + defer func() { _ = resp.Body.Close() }() + if resp.StatusCode != http.StatusBadRequest { + b, _ := io.ReadAll(resp.Body) + t.Fatalf("status=%d want 400 body=%s", resp.StatusCode, b) + } + b, _ := io.ReadAll(resp.Body) + if !strings.Contains(string(b), "schema_version") { + t.Fatalf("body=%s", b) + } +} + +func TestIngestAcceptsV1SchemaAndHeartbeat(t *testing.T) { + st, srv := newSecurityTestServer(t) + defer st.Close() + defer srv.Close() + + suffix := fmt.Sprintf("%d", time.Now().UnixNano()) + deposit := domain.Event{ + EventID: "schema-v1-" + suffix, + TenantID: "acme-casino", + PlayerID: "schema-player-" + suffix, + Type: domain.EventDeposit, + Amount: 50, + SchemaVersion: domain.EventSchemaV1, + OccurredAt: time.Now().UTC(), + } + postAccepted(t, srv.URL, deposit) + + hb := domain.Event{ + EventID: "schema-hb-" + suffix, + TenantID: "acme-casino", + PlayerID: deposit.PlayerID, + Type: domain.EventSessionHeartbeat, + SchemaVersion: domain.EventSchemaV1, + OccurredAt: time.Now().UTC(), + } + postAccepted(t, srv.URL, hb) +} + +func postAccepted(t *testing.T, base string, evt domain.Event) { + t.Helper() + body, err := json.Marshal(evt) + if err != nil { + t.Fatalf("marshal: %v", err) + } + req, err := http.NewRequest(http.MethodPost, base+"/v1/events", bytes.NewReader(body)) + if err != nil { + t.Fatalf("request: %v", err) + } + req.Header.Set("Content-Type", "application/json") + req.Header.Set("X-Signature", ingest.Sign("hmac_acme_dev_secret", body)) + resp, err := http.DefaultClient.Do(req) + if err != nil { + t.Fatalf("do: %v", err) + } + defer func() { _ = resp.Body.Close() }() + if resp.StatusCode != http.StatusAccepted { + b, _ := io.ReadAll(resp.Body) + t.Fatalf("status=%d want 202 body=%s", resp.StatusCode, b) + } +} diff --git a/internal/ingest/validate_test.go b/internal/ingest/validate_test.go new file mode 100644 index 0000000..560e87b --- /dev/null +++ b/internal/ingest/validate_test.go @@ -0,0 +1,52 @@ +package ingest + +import ( + "strings" + "testing" + "time" + + "github.com/o-mid/engagepulse/internal/domain" +) + +func TestValidateEventAcceptsMissingAndV1Schema(t *testing.T) { + base := domain.Event{ + EventID: "schema-ok", + TenantID: "acme-casino", + PlayerID: "p1", + Type: domain.EventDeposit, + Amount: 50, + OccurredAt: time.Now().UTC(), + } + if err := ValidateEvent(base); err != nil { + t.Fatalf("missing version: %v", err) + } + base.SchemaVersion = domain.EventSchemaV1 + if err := ValidateEvent(base); err != nil { + t.Fatalf("v1: %v", err) + } + hb := base + hb.Type = domain.EventSessionHeartbeat + hb.Amount = 0 + if err := ValidateEvent(hb); err != nil { + t.Fatalf("heartbeat: %v", err) + } +} + +func TestValidateEventRejectsUnknownSchema(t *testing.T) { + evt := domain.Event{ + EventID: "schema-bad", + TenantID: "acme-casino", + PlayerID: "p1", + Type: domain.EventDeposit, + Amount: 50, + SchemaVersion: 2, + OccurredAt: time.Now().UTC(), + } + err := ValidateEvent(evt) + if err == nil { + t.Fatal("expected error") + } + if !strings.Contains(err.Error(), "schema_version") { + t.Fatalf("err=%v", err) + } +} From 37618e394782ba06c2ed921af989fcdefd5b2ca3 Mon Sep 17 00:00:00 2001 From: Omid Mirzaei Date: Fri, 18 Sep 2026 13:48:02 +0400 Subject: [PATCH 3/4] keep session heartbeats off the welcome credit --- internal/rules/engine_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/internal/rules/engine_test.go b/internal/rules/engine_test.go index 8d4a319..9999294 100644 --- a/internal/rules/engine_test.go +++ b/internal/rules/engine_test.go @@ -38,6 +38,13 @@ func TestApplyWelcome(t *testing.T) { wantTag: false, credit: 0, }, + { + name: "heartbeat", + evt: domain.Event{Type: domain.EventSessionHeartbeat, SchemaVersion: domain.EventSchemaV1}, + st: store.PlayerState{}, + wantTag: false, + credit: 0, + }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { From b532fa400b2428e95017c25b66248bb2fb5cf795 Mon Sep 17 00:00:00 2001 From: Omid Mirzaei Date: Fri, 18 Sep 2026 13:48:02 +0400 Subject: [PATCH 4/4] document schema_version on ingest --- README.md | 2 +- docs/architecture.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index bcb793e..22402cb 100644 --- a/README.md +++ b/README.md @@ -96,7 +96,7 @@ make demo | What | Path | | --- | --- | -| Send event | `POST /v1/events` (header `X-Signature`, optional `X-Key-Id`) | +| Send event | `POST /v1/events` (header `X-Signature`, optional `X-Key-Id`; `schema_version` omitted or `1`) | | Rotate HMAC | `POST /v1/hmac/rotate` (header `X-API-Key`; overlap for that brand only) | | Read player | `GET /v1/players/{id}` (header `X-API-Key`) | | List dead letters | `GET /v1/dlq` (header `X-API-Key`) | diff --git a/docs/architecture.md b/docs/architecture.md index 3bf9635..f4b6117 100644 --- a/docs/architecture.md +++ b/docs/architecture.md @@ -28,7 +28,7 @@ loadgen / partner | v POST /v1/events - - check JSON + - check JSON (`schema_version` omitted or 1; unknown versions 400) - check brand secret (HMAC signature, optional X-Key-Id) - save row in outbox table - reply 202 Accepted