Fix NuRouteSettings comparison and add unit tests#120
Open
mateussiqueira wants to merge 1 commit into
Open
Conversation
- Implemented proper hashCode and equality operator in NuRouteSettings - Added unit tests to verify parameter merging and object comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aqui está uma sugestão de descrição para o Pull Request em inglês:
Description
This PR fixes the comparison logic for the
NuRouteSettingsclass and adds unit tests to ensure its correctness.Changes
hashCodeand equality operator (==) in theNuRouteSettingsclass.NuRouteSettingsinstances.Motivation and Context
The previous implementation of the
NuRouteSettingsclass had issues with object comparison, causing tests to fail. This fix ensures thatNuRouteSettingsinstances are compared correctly, which is crucial for the functionality of the routing system.How Has This Been Tested?
NuRouteSettingsinstances with the same parameters.Screenshots (if appropriate)
N/A
Types of changes
Checklist
Use esta descrição ao criar o Pull Request no seu repositório.