Allow units in different languages

[niksy]

Is it possible to add support for units in different languages? Will you be willing to accept PR for this?

[suprmat95]

@nsafai
Also for me it would be really interesting, because I would use the parser in my project, but I need the Italian language. If you want I can translate all units of measurement into Italian.

[nsafai]

Hey @niksy sorry I missed your comment. Just seeing it now. @suprmat95 glad you commented so this got brought to my attention.

I would be willing to accept a PR to add support for different languages.

My only concern would be that if we created one gigantic list of units for all languages, it’s possible it would have unintended side effects.

My suggested implementation would be something like this:
1- have a map (=list) of supported languages that maps to their respective list of units.
2- pass language as a parameter to the parsing functions and fetch the correct units from the map in (1)

What do you think?

[suprmat95]

Hi @niksy I agree with your suggestions. I can do this improvement translating units in Italian :D

[suprmat95]

Can I also add some other units that could be useful for my project?

[nsafai]

Would these other units be useful to others or exclusively your project? Can you share some examples?

…

On Mar 1, 2021, 03:36 -0800, suprmat95 ***@***.***>, wrote: Can I also add some other units that could be useful for my project? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[suprmat95]

absolutely for everyone:

• leaf of parsley -> foglia di prezzemolo
• sachet of vanilla flavouring - > bustina di vanillina
• stick of yeast -> panetto di lievito

[nsafai]

In this case, I think the unit would just be this part: leaf/foglia sachet/bustina stick/panetto Right?

…

On Mar 1, 2021, 08:36 -0800, suprmat95 ***@***.***>, wrote: absolutely for everyone: • leaf of parsley -> foglia di prezzemolo • sachet of vanilla flavouring - > bustina di vanillina • stick of yeast -> panetto di lievito — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[suprmat95]

yes It's right!

[suprmat95]

@nsafai can you give me the permissions to push a branch and to a new pull request?

[nsafai]

Hey @suprmat95 you don't have permission to push to master but you should have permission to raise a PR. A couple other people (who I haven't given any special permissions to) are able to raise PRs https://github.com/nsafai/recipe-parser/pulls

[suprmat95]

@nsafai Done! Thankyou 😊