From 312cd30e00cc8eb998c3c01b2c3ce0e46f6e4583 Mon Sep 17 00:00:00 2001 From: inoway46 Date: Wed, 16 Sep 2026 19:50:03 +0900 Subject: [PATCH] test: move permission FFI test to native suite Move the permission drop test to the FFI suite so test-ci-js does not require the native FFI fixture library. Update the helper import to match the new location. Synchronize the Windows native suites with the Makefile by including ffi. Build its fixture for test-ci-native, but not for test-ci-js. Fixes: https://github.com/nodejs/node/issues/66055 Refs: https://github.com/nodejs/node/pull/63165 Assisted-by: Codex Signed-off-by: inoway46 --- .../test-ffi-permission-drop.js} | 2 +- vcbuild.bat | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) rename test/{parallel/test-permission-drop-ffi.js => ffi/test-ffi-permission-drop.js} (90%) diff --git a/test/parallel/test-permission-drop-ffi.js b/test/ffi/test-ffi-permission-drop.js similarity index 90% rename from test/parallel/test-permission-drop-ffi.js rename to test/ffi/test-ffi-permission-drop.js index 84d5877b1e0d..275499503e6b 100644 --- a/test/parallel/test-permission-drop-ffi.js +++ b/test/ffi/test-ffi-permission-drop.js @@ -2,7 +2,7 @@ 'use strict'; const common = require('../common'); -const { fixtureSymbols, libraryPath } = require('../ffi/ffi-test-common'); +const { fixtureSymbols, libraryPath } = require('./ffi-test-common'); common.skipIfFFIMissing(); diff --git a/vcbuild.bat b/vcbuild.bat index 9f6a4884dc86..614346405747 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -11,7 +11,7 @@ if /i "%arg:~-4%"=="help" goto help cd %~dp0 set JS_SUITES=default -set NATIVE_SUITES=addons js-native-api node-api embedding +set NATIVE_SUITES=addons ffi js-native-api node-api embedding @rem CI_* variables should be kept synchronized with the ones in Makefile set "CI_NATIVE_SUITES=%NATIVE_SUITES% benchmark" set "CI_JS_SUITES=%JS_SUITES% pummel" @@ -119,7 +119,7 @@ if /i "%1"=="v8windbg" set v8windbg=1&goto arg-ok if /i "%1"=="licensertf" set licensertf=1&goto arg-ok if /i "%1"=="test" set test_args=%test_args% %common_test_suites%&set lint_cpp=1&set lint_js=1&set lint_md=1&goto arg-ok if /i "%1"=="test-ci-native" set test_args=%test_args% %test_ci_args% -p tap --logfile test.tap %CI_NATIVE_SUITES% %CI_DOC%&set build_addons=1&set build_js_native_api_tests=1&set build_node_api_tests=1&set build_ffi_tests=1&set cctest_args=%cctest_args% --gtest_output=xml:cctest.junit.xml&goto arg-ok -if /i "%1"=="test-ci-js" set test_args=%test_args% %test_ci_args% -p tap --logfile test.tap %CI_JS_SUITES%&set build_ffi_tests=1&set no_cctest=1&goto arg-ok +if /i "%1"=="test-ci-js" set test_args=%test_args% %test_ci_args% -p tap --logfile test.tap %CI_JS_SUITES%&set no_cctest=1&goto arg-ok if /i "%1"=="build-addons" set build_addons=1&goto arg-ok if /i "%1"=="build-js-native-api-tests" set build_js_native_api_tests=1&goto arg-ok if /i "%1"=="build-node-api-tests" set build_node_api_tests=1&goto arg-ok