bug in `nimble.Makevars.file` option in `createMakevars`?

[paciorek]

I see this in the definition of createMakevars()

function(pkgFlags, pkgLibs, ..., dir = getwd(), 
         .copyFrom = getOption("nimble.Makevars.file",

but that seems to be trying to find an R option not a nimble option.

@perrydv thoughts? Is this the mechanism by which a user is supposed to be able to affect the Makevars in nimble_generatedCode?

(Also as a side note, if a user did this, would they also need to put into their Makevars all the stuff we have in Makevars_lib?)

[perrydv]

@paciorek My guess is that this was a backdoor option to manually control where Makevars could be copied from by way of setting an R option. Note that one can set arbtirary base R options, although I'm not sure why that would have been used instead of a nimble option. My guess is that in early development it was (or seemed) helpful to sometimes have more manual control over the Makevars, but I can't imagine anyone anywhere is using this because it appears to be undocumented and something we have rather lost track of. On the other hand, it is not necessarily harmful. I would say we could either leave as is or deprecate by setting the default of .copyFrom to the current second argument of getOption (which in practice serves as the default since the getOption will return NULL). It seems more like dreck than a bug.