From d769e29e0c3a80964c9783e293de3a4077b02a6b Mon Sep 17 00:00:00 2001 From: Lukas1811 <40807034+Lukas1811@users.noreply.github.com> Date: Sat, 28 Feb 2026 19:49:04 +0100 Subject: [PATCH] Fixed possible ImGui assertions In both cases it was possible that BeginChild was called but not EndChild --- src/ngscopeclient/CreateFilterBrowser.cpp | 3 ++- src/ngscopeclient/MainWindow.cpp | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ngscopeclient/CreateFilterBrowser.cpp b/src/ngscopeclient/CreateFilterBrowser.cpp index 57b025bf6..ea97e72a3 100644 --- a/src/ngscopeclient/CreateFilterBrowser.cpp +++ b/src/ngscopeclient/CreateFilterBrowser.cpp @@ -221,8 +221,9 @@ bool CreateFilterBrowser::DoRender() DrawIconButton(draw_list, pos, color, icon, caption); } - ImGui::EndChild(); } + + ImGui::EndChild(); return true; } diff --git a/src/ngscopeclient/MainWindow.cpp b/src/ngscopeclient/MainWindow.cpp index d5348a38c..ad7ff2fc6 100644 --- a/src/ngscopeclient/MainWindow.cpp +++ b/src/ngscopeclient/MainWindow.cpp @@ -1930,8 +1930,9 @@ void MainWindow::RenderLoadWarningPopup() ImGuiChildFlags_Borders | ImGuiChildFlags_ResizeY)) { ImGui::Markdown( m_session.m_setupNotes.c_str(), m_session.m_setupNotes.length(), GetMarkdownConfig()); - ImGui::EndChild(); } + + ImGui::EndChild(); } //If we have config warnings, show them