From c682887e518d8b8da5037bbc8103c9de5e776766 Mon Sep 17 00:00:00 2001 From: Jover Lee Date: Wed, 15 Nov 2023 13:07:21 -0800 Subject: [PATCH] Fix ingest uploads Fix bug that was introduced in https://github.com/nextstrain/mpox/pull/222 The testing done on branch runs do not include the Slack notifications, so this bug was not revealed in the test run. I only noticed the workflow as failing because our internal #monkeypox-updates channel had been quiet for over a week. This did not trigger our usual error notifications in Slack because the error occurs during the DAG building process before the start of the actual workflow run. --- ingest/workflow/snakemake_rules/upload.smk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ingest/workflow/snakemake_rules/upload.smk b/ingest/workflow/snakemake_rules/upload.smk index 60c5c9b7..a5270ffe 100644 --- a/ingest/workflow/snakemake_rules/upload.smk +++ b/ingest/workflow/snakemake_rules/upload.smk @@ -35,9 +35,9 @@ def _get_upload_inputs(wildcards): if send_notifications: flag_file = [] - if file_to_upload == "data/genbank.ndjson": + if inputs["file_to_upload"] == "data/genbank.ndjson": flag_file = "data/notify/genbank-record-change.done" - elif file_to_upload == "results/metadata.tsv": + elif inputs["file_to_upload"] == "results/metadata.tsv": flag_file = "data/notify/metadata-diff.done" inputs["notify_flag_file"] = flag_file