From 39faf75b6904a9e3d3242b4ca7ba77af65248141 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Mon, 25 May 2026 15:42:41 +0200 Subject: [PATCH 1/2] fix: Allow accessing signaling settings to admins that can not use Talk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since Talk 21 the connection check for the signaling server in Talk administration settings fetches the signaling settings, so admins should be allowed to access the endpoint even if they do not belong to any of the groups allowed to use Talk. Signed-off-by: Daniel Calviño Sánchez --- lib/Middleware/CanUseTalkMiddleware.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/Middleware/CanUseTalkMiddleware.php b/lib/Middleware/CanUseTalkMiddleware.php index 88becb4f945..6396dc6e868 100644 --- a/lib/Middleware/CanUseTalkMiddleware.php +++ b/lib/Middleware/CanUseTalkMiddleware.php @@ -90,6 +90,12 @@ public function beforeController(Controller $controller, string $methodName): vo return; } + if ($methodName === 'getSettings' + && $controller instanceof SignalingController + && $this->groupManager->isAdmin($user->getUID())) { + return; + } + if ($controller instanceof HostedSignalingServerController && $this->groupManager->isAdmin($user->getUID())) { return; From a395779b5f68ca8802673e4d7563e3abf7c19c1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Wed, 27 May 2026 07:52:16 +0200 Subject: [PATCH 2/2] fix: Allow accessing bot list to admins that can not use Talk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Talk administration settings fetches the list of all bots, so admins should be allowed to access the endpoint even if they do not belong to any of the groups allowed to use Talk. Signed-off-by: Daniel Calviño Sánchez --- lib/Middleware/CanUseTalkMiddleware.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/Middleware/CanUseTalkMiddleware.php b/lib/Middleware/CanUseTalkMiddleware.php index 6396dc6e868..9d7528aa8fe 100644 --- a/lib/Middleware/CanUseTalkMiddleware.php +++ b/lib/Middleware/CanUseTalkMiddleware.php @@ -9,6 +9,7 @@ namespace OCA\Talk\Middleware; use OCA\Talk\Config; +use OCA\Talk\Controller\BotController; use OCA\Talk\Controller\HostedSignalingServerController; use OCA\Talk\Controller\RecordingController; use OCA\Talk\Controller\SignalingController; @@ -101,6 +102,12 @@ public function beforeController(Controller $controller, string $methodName): vo return; } + if ($methodName === 'adminListBots' + && $controller instanceof BotController + && $this->groupManager->isAdmin($user->getUID())) { + return; + } + throw new CanNotUseTalkException(); }