fix(settings): let a failed app token creation surface to the user

addToken swallowed every error from the request and returned null, so the
catch in AuthTokenSetup never ran. Creating an app password against a
blocked or failing endpoint left the form silently doing nothing.

Drop the catch and let the rejection reach the caller, which already logs it
and shows an error, the same way updateToken leaves reporting to its callers.

Fixes #62680

Signed-off-by: ELHart05 <o.allaoua@esi-sba.dz>

Author: ELHart05

apps/settings/src/store/authtoken.spec.ts

@@ -0,0 +1,52 @@
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import type { IToken } from './authtoken.ts'
+
+import axios from '@nextcloud/axios'
+import { createPinia, setActivePinia } from 'pinia'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { TokenType, useAuthTokenStore } from './authtoken.ts'
+
+vi.mock('@nextcloud/axios')
+vi.mock('@nextcloud/initial-state')
+
+const deviceToken: IToken = {
+	id: 7,
+	name: 'Laptop',
+	type: TokenType.PERMANENT_TOKEN,
+	lastActivity: 1700000000,
+	canDelete: true,
+	canRename: true,
+	scope: { filesystem: true },
+}
+
+describe('store:authtoken addToken', () => {
+	beforeEach(() => {
+		setActivePinia(createPinia())
+		vi.restoreAllMocks()
+	})
+
+	it('keeps the created token', async () => {
+		vi.spyOn(axios, 'post').mockResolvedValue({
+			data: { deviceToken, loginName: 'alice', token: 'secret' },
+		})
+
+		const store = useAuthTokenStore()
+		const response = await store.addToken('Laptop')
+
+		expect(response.deviceToken).toBe(deviceToken)
+		expect(store.tokens).toContain(deviceToken)
+	})
+
+	it('lets a failed request reach the caller so it can be reported', async () => {
+		vi.spyOn(axios, 'post').mockRejectedValue(new Error('Request failed'))
+
+		const store = useAuthTokenStore()
+
+		await expect(store.addToken('Laptop')).rejects.toThrow('Request failed')
+		expect(store.tokens).toHaveLength(0)
+	})
+})

apps/settings/src/store/authtoken.ts

@@ -75,15 +75,13 @@ export const useAuthTokenStore = defineStore('auth-token', {
 		async addToken(name: string) {
 			logger.debug('Creating a new app token')
 
-			try {
-				const { data } = await axios.post<ITokenResponse>(BASE_URL, { name, oneTime: true }, { confirmPassword: PwdConfirmationMode.Strict })
+			// Let the failure reach the caller: AuthTokenSetup is the one that
+			// reports it, the same way updateToken leaves reporting to its callers.
+			const { data } = await axios.post<ITokenResponse>(BASE_URL, { name, oneTime: true }, { confirmPassword: PwdConfirmationMode.Strict })
 
-				this.tokens.push(data.deviceToken)
-				logger.debug('App token created')
-				return data
-			} catch {
-				return null
-			}
+			this.tokens.push(data.deviceToken)
+			logger.debug('App token created')
+			return data
 		},
 
 		/**