Repository navigation
Commit 8399918
committed
chore: migrate to @nextcloud/eslint-config 9
Its ESLint 10 reads a flat config only, so .eslintrc.cjs becomes eslint.config.js,
whose rules apply to the app sources, leaving the exemptions version 9 grants test
files in place. The lint workflow watched .eslintrc.* and .eslintignore, neither of
which exists any more, and webpack.js was the last place configuring ESLint the old
way: nothing declares its dependencies, so it could not run at all.
The import rules are gone from the shared config, so 'import/extensions' goes with
them, as do the babel parser options and the appVersion global the sources do not
use, which the shared config declares anyway. 'no-console' was built into the old
config and is now spelled out.
The sources follow what the new rules ask for: sorted imports, blank lines between
multi line component options, and camel cased attributes and events in templates.
Unused callback parameters are gone, one rule asks for the ellipsis character in a
translatable string, so 'Loading...' became 'Loading…', and the dashboard component
is called GithubDashboard, because a name of one word can collide with an HTML
element.
Two findings needed a decision. NcPopover was given focusTrap, which
@nextcloud/vue 9 does not declare any more, so asking for the focus trap to be off
did nothing and the popover kept building a trap it does not need. The .native
modifier of three mouse listeners is one the Vue 3 compiler drops while keeping the
listener, so removing it changes nothing; that holds for these three, not for key
events, where the modifier is compiled as a key name and swallows the handler.
Folding a comment and the popover of a comment author had no test, and now have one.
eslint.config.js has no place in the released archive, and the .eslintrc.js the
packaging lists named never existed here.
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
The widget passed its label to the dashboard component as 'showMoreText'. The prop is
called showMoreLabel, so the link under a full widget read 'More items …' instead of
what the widget asked for.
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
The lint scripts passed --ext, which ESLint 10 ignores, and the change filter of the
build did not watch the config file the build now reads.
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
The link under a full widget had no test, and now has one.
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>1 parent 5416c02 commit 8399918
33 files changed
Lines changed: 1349 additions & 3319 deletions
File tree
- .github/workflows
- playwright/e2e
- src
- components
- icons
- views
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
| 40 | + | |
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| |||
0 commit comments