I noticed there's only publish.yml, triggered on push: tags: ["v*"] — there's no workflow running on push/PR to master or develop. That means code merges into develop/master with no lint/vet/test check, and the only test run (go test ./...) is gated behind if: matrix.isPublisher, so it only executes for the windows-amd64 matrix leg — linux and darwin builds never run tests, even at release time.
I'd add a ci.yml that runs on PR/push to master and develop:
on:
pull_request:
branches: [master, develop]
push:
branches: [master, develop]
jobs:
checks:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.24.5"
- run: go vet ./...
- run: go test ./...Related issues
I noticed there's only
publish.yml, triggered onpush: tags: ["v*"]— there's no workflow running on push/PR tomasterordevelop. That means code merges intodevelop/masterwith no lint/vet/test check, and the only test run (go test ./...) is gated behindif: matrix.isPublisher, so it only executes for thewindows-amd64matrix leg — linux and darwin builds never run tests, even at release time.I'd add a
ci.ymlthat runs on PR/push tomasteranddevelop:Related issues
NPM_TOKEN/NODE_AUTH_TOKENenv vars: Remove unused NPM_TOKEN/NODE_AUTH_TOKEN env vars in publish.yml #21