Skip to content

As a developer, I want to fix empty official_doc_urls in 9 nabledge-1.4 knowledge files so that S11 checks pass #239

@kiyotis

Description

@kiyotis

Situation

9 nabledge-1.4 knowledge files have an empty string ("") in their official_doc_urls array, causing Phase C S11 (URL not https) check failures.

Root cause: _compute_official_url in phase_b_generate.py returns "" when the RST file path does not contain nablarch-document/ja/. This empty string is passed to Phase B as {OFFICIAL_DOC_BASE_URL}. Phase B's Step 6 instructs the model to start official_doc_urls with {OFFICIAL_DOC_BASE_URL}, so the empty string is included in the output array as-is.

An empty URL is not an error state — it means no public URL exists for that file. The correct output is an empty array [], not [""].

Pain

S11 check failures on these 9 files reduce confidence in quality metrics and cause false negatives in Phase C results.

Benefit

  • official_doc_urls correctly represents the absence of a URL as [] rather than [""]
  • S11 check passes for these 9 files

Success Criteria

  • _compute_official_url returns None or is omitted from the prompt when no URL exists, so Phase B does not include an empty string in official_doc_urls
  • All 9 affected files have official_doc_urls with no empty strings
  • Phase C S11 check passes for all 9 files

Affected Files

File ID Empty URL count
testing-framework-03_Tips--s10 1
web-application-04_validation--s1 1
libraries-07_FormTag--s16 1
libraries-01_Log--s1 1
libraries-04_ObjectSave--s5 1
about-nablarch-concept--s13 1
web-application-web_gui--s1 1
workflow-WorkflowProcessElement--s1 1
ui-framework-ui_development_workflow--s1 1

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions