Vitest tests fail with error "Cannot find package 'graphql' imported" in v2.4.0

[am-ma]

Prerequisites

• I confirm my issue is not in the opened issues
• I confirm the Frequently Asked Questions didn't contain the answer to my issue

Environment check

• I'm using the latest msw version
• I'm using Node.js version 18 or higher

Node.js version

v20.10.0

Reproduction repository

https://github.com/am-ma/msw2.4.0-examples-for-issue/tree/main/examples/with-vitest

Reproduction steps

1. Upgrade nsw to v2.4.0
2. Run tests <- error occurred

Current behavior

All tests fail.

 FAIL  example-jsdom.test.ts [ example-jsdom.test.ts ]
 FAIL  example.test.ts [ example.test.ts ]
Error: Cannot find package 'graphql' imported from {userDir}/msw2.4.0-examples-for-issue/examples/with-vitest/node_modules/msw/lib/core/utils/internal/parseGraphQLRequest.mjs

Expected behavior

Tests succeed without error.

[nartc]

We ran into the same thing here #2247

[CAcarSci]

I have the same issue here. Installing the graphql package npm i graphql solves the error. However, this means that the latest version of MSW does not make the graphql dependency optional.

[ghost91-]

Also happens to us with jest:

  ● Test suite failed to run

    Cannot find module 'graphql' from '../../node_modules/msw/lib/core/utils/internal/parseGraphQLRequest.js'

    Require stack:
      /home/.../node_modules/msw/lib/core/utils/internal/parseGraphQLRequest.js
      /home/.../node_modules/msw/lib/core/handlers/GraphQLHandler.js
      /home/.../node_modules/msw/lib/core/graphql.js
      /home/.../node_modules/msw/lib/core/index.js

[THETCR]

@kettanaito
You only added graphql to peerDependenciesMeta and forget to actually add the dependency under peerDependencies.

[kettanaito]

@THETCR, great catch! This, alongside the fix I described here should resolve the issue.

[THETCR]

@kettanaito
The correct fix would be as in #2249