From 3015229b472bcc6b9ea6ba910a847596ec49912f Mon Sep 17 00:00:00 2001 From: Antoine Boot <2473792+Antiohne@users.noreply.github.com> Date: Sun, 22 Feb 2026 11:46:39 +0100 Subject: [PATCH 1/2] Make ListMemberships the default to prevent the AmbiguousParameterSet error --- docs/Get-AdoMembership.md | 68 +++++++++---------- .../Graph/Memberships/Get-AdoMembership.ps1 | 2 +- .../Memberships/Get-AdoMembership.Tests.ps1 | 4 +- 3 files changed, 37 insertions(+), 37 deletions(-) diff --git a/docs/Get-AdoMembership.md b/docs/Get-AdoMembership.md index 5f97637..dfb92af 100644 --- a/docs/Get-AdoMembership.md +++ b/docs/Get-AdoMembership.md @@ -1,10 +1,10 @@ @@ -17,18 +17,18 @@ Get membership relationships ## SYNTAX -### GetMembership +### ListMemberships (Default) -```text -Get-AdoMembership [[-CollectionUri] ] [-SubjectDescriptor] - [-ContainerDescriptor] [[-Version] ] [] +```powershell +Get-AdoMembership -SubjectDescriptor [-CollectionUri ] [-Depth ] + [-Direction ] [-Version ] [] ``` -### ListMemberships +### GetMembership -```text -Get-AdoMembership [[-CollectionUri] ] [-SubjectDescriptor] - [[-Depth] ] [[-Direction] ] [[-Version] ] [] +```powershell +Get-AdoMembership -SubjectDescriptor [-CollectionUri ] + [-ContainerDescriptor ] [-Version ] [] ``` ## ALIASES @@ -128,28 +128,6 @@ AcceptedValues: [] HelpMessage: '' ``` -### -SubjectDescriptor - -Mandatory. -A descriptor to the child subject in the relationship. - -```yaml -Type: System.String[] -DefaultValue: '' -SupportsWildcards: false -Aliases: [] -ParameterSets: -- Name: (All) - Position: Named - IsRequired: true - ValueFromPipeline: true - ValueFromPipelineByPropertyName: true - ValueFromRemainingArguments: false -DontShow: false -AcceptedValues: [] -HelpMessage: '' -``` - ### -ContainerDescriptor Optional. @@ -180,7 +158,7 @@ Default is 1. ```yaml Type: System.Int32 -DefaultValue: '' +DefaultValue: 0 SupportsWildcards: false Aliases: [] ParameterSets: @@ -222,6 +200,28 @@ AcceptedValues: HelpMessage: '' ``` +### -SubjectDescriptor + +Mandatory. +A descriptor to the child subject in the relationship. + +```yaml +Type: System.String[] +DefaultValue: '' +SupportsWildcards: false +Aliases: [] +ParameterSets: +- Name: (All) + Position: Named + IsRequired: true + ValueFromPipeline: true + ValueFromPipelineByPropertyName: true + ValueFromRemainingArguments: false +DontShow: false +AcceptedValues: [] +HelpMessage: '' +``` + ### -Version Optional. diff --git a/src/Azure.DevOps.PSModule/Public/Graph/Memberships/Get-AdoMembership.ps1 b/src/Azure.DevOps.PSModule/Public/Graph/Memberships/Get-AdoMembership.ps1 index 1d0c7b4..94c7fd2 100644 --- a/src/Azure.DevOps.PSModule/Public/Graph/Memberships/Get-AdoMembership.ps1 +++ b/src/Azure.DevOps.PSModule/Public/Graph/Memberships/Get-AdoMembership.ps1 @@ -76,7 +76,7 @@ Retrieves all memberships of a group with a depth of 2. #> - [CmdletBinding()] + [CmdletBinding(DefaultParameterSetName = 'ListMemberships')] param ( [Parameter(ValueFromPipelineByPropertyName)] [ValidateScript({ Confirm-CollectionUri -Uri $_ })] diff --git a/src/Azure.DevOps.PSModule/Tests/Graph/Memberships/Get-AdoMembership.Tests.ps1 b/src/Azure.DevOps.PSModule/Tests/Graph/Memberships/Get-AdoMembership.Tests.ps1 index fa642fb..8bcfd2c 100644 --- a/src/Azure.DevOps.PSModule/Tests/Graph/Memberships/Get-AdoMembership.Tests.ps1 +++ b/src/Azure.DevOps.PSModule/Tests/Graph/Memberships/Get-AdoMembership.Tests.ps1 @@ -188,11 +188,11 @@ Describe 'Get-AdoMembership' { It 'Should include Direction query parameter when specified' { # Act - Get-AdoMembership -CollectionUri $mockCollectionUri -SubjectDescriptor $mockSubjectDescriptor -Direction 'up' + Get-AdoMembership -CollectionUri $mockCollectionUri -SubjectDescriptor $mockSubjectDescriptor -Direction 'down' # Assert Should -Invoke Invoke-AdoRestMethod -ModuleName Azure.DevOps.PSModule -Times 1 -ParameterFilter { - $QueryParameters -eq 'direction=up' + $QueryParameters -eq 'direction=down' } } From b2e97dad106bee23a0361482be8596189d226e54 Mon Sep 17 00:00:00 2001 From: Antoine Boot <2473792+Antiohne@users.noreply.github.com> Date: Sun, 22 Feb 2026 11:56:47 +0100 Subject: [PATCH 2/2] Revert unit test change (#143) --- .../Tests/Graph/Memberships/Get-AdoMembership.Tests.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Azure.DevOps.PSModule/Tests/Graph/Memberships/Get-AdoMembership.Tests.ps1 b/src/Azure.DevOps.PSModule/Tests/Graph/Memberships/Get-AdoMembership.Tests.ps1 index 8bcfd2c..fa642fb 100644 --- a/src/Azure.DevOps.PSModule/Tests/Graph/Memberships/Get-AdoMembership.Tests.ps1 +++ b/src/Azure.DevOps.PSModule/Tests/Graph/Memberships/Get-AdoMembership.Tests.ps1 @@ -188,11 +188,11 @@ Describe 'Get-AdoMembership' { It 'Should include Direction query parameter when specified' { # Act - Get-AdoMembership -CollectionUri $mockCollectionUri -SubjectDescriptor $mockSubjectDescriptor -Direction 'down' + Get-AdoMembership -CollectionUri $mockCollectionUri -SubjectDescriptor $mockSubjectDescriptor -Direction 'up' # Assert Should -Invoke Invoke-AdoRestMethod -ModuleName Azure.DevOps.PSModule -Times 1 -ParameterFilter { - $QueryParameters -eq 'direction=down' + $QueryParameters -eq 'direction=up' } }