Follow-up to #236 (phase-space limiting in LineRatioFit.run).
The radiation_field_range / density_range keywords added in #236 restrict the fit, but the plotting layer does not yet indicate the restricted region. Specifically:
LineRatioFit.chisq(min=False) / reduced_chisq(min=False) still return the full, unmasked chi-squared surface (this is intentional — the excluded region is masked only on local copies during the coarse argmin, so the stored cubes are untouched).
- As a result,
LineRatioPlot renders the entire phase space, with the best-fit marker sitting inside the restricted window and no visual cue about what was excluded.
Proposed enhancement
When phase-space limits were used in the fit, have the phase-space / chi-squared plots (LineRatioPlot) shade or grey out the excluded G0/n region (or draw the allowed-window boundary), so it is visually clear which part of parameter space was ruled out by the limits versus by the data.
Notes / open questions
- The limits are stored on the tool as
LineRatioFit._radiation_field_range and LineRatioFit._density_range (linear model units, None = unrestricted), so the plot layer can read them directly.
- Decide whether the default should be to shade automatically whenever limits were applied, or to gate it behind a plot keyword.
- Keep the returned chi-squared cubes unmasked (do not change the fit-side behavior); this is purely a visualization concern.
Follow-up to #236 (phase-space limiting in
LineRatioFit.run).The
radiation_field_range/density_rangekeywords added in #236 restrict the fit, but the plotting layer does not yet indicate the restricted region. Specifically:LineRatioFit.chisq(min=False)/reduced_chisq(min=False)still return the full, unmasked chi-squared surface (this is intentional — the excluded region is masked only on local copies during the coarse argmin, so the stored cubes are untouched).LineRatioPlotrenders the entire phase space, with the best-fit marker sitting inside the restricted window and no visual cue about what was excluded.Proposed enhancement
When phase-space limits were used in the fit, have the phase-space / chi-squared plots (
LineRatioPlot) shade or grey out the excludedG0/nregion (or draw the allowed-window boundary), so it is visually clear which part of parameter space was ruled out by the limits versus by the data.Notes / open questions
LineRatioFit._radiation_field_rangeandLineRatioFit._density_range(linear model units,None= unrestricted), so the plot layer can read them directly.