From d8a9eedd1b100185d04de1edaa789dd060d263f7 Mon Sep 17 00:00:00 2001 From: "Utilu.com" Date: Mon, 5 Oct 2015 14:58:29 +0200 Subject: [PATCH 1/3] Added spaces between the extensions when copying the list of extensions to the Clipboard When the list of extensions is copied to the Clipboard and pasted on a location where newlines are not allowed, the extensions get glued together: Firebug 3.0.0-alpha.14Utilu Nightly Tester Tools 3.7.1.1Web Developer 1.2.7 After this change there is a space between the extensions: Firebug 3.0.0-alpha.14 Utilu Nightly Tester Tools 3.7.1.1 Web Developer 1.2.7 --- extension/chrome/content/nightly.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extension/chrome/content/nightly.js b/extension/chrome/content/nightly.js index 29d8d06..3db3d84 100644 --- a/extension/chrome/content/nightly.js +++ b/extension/chrome/content/nightly.js @@ -361,7 +361,7 @@ getExtensionList: function(callback) { + (addon.userDisabled || addon.appDisabled ? " [DISABLED]" : ""); }); strings.sort(nightly.insensitiveSort); - callback(strings.join("\n")); + callback(strings.join(" \n")); }); } catch(e) { // old extension manager API - take out after Firefox 3.6 support dropped @@ -395,7 +395,7 @@ getExtensionList: function(callback) { catch (e) { } } text.sort(nightly.insensitiveSort); - callback(text.join("\n")); + callback(text.join(" \n")); } }, From ddeb1c6134469b186fe4b732158d2495fd74c275 Mon Sep 17 00:00:00 2001 From: "Utilu.com" Date: Wed, 21 Oct 2015 16:05:35 +0200 Subject: [PATCH 2/3] Changed newlines-separation to comma-separation --- extension/chrome/content/nightly.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extension/chrome/content/nightly.js b/extension/chrome/content/nightly.js index 3db3d84..a0c1396 100644 --- a/extension/chrome/content/nightly.js +++ b/extension/chrome/content/nightly.js @@ -361,7 +361,7 @@ getExtensionList: function(callback) { + (addon.userDisabled || addon.appDisabled ? " [DISABLED]" : ""); }); strings.sort(nightly.insensitiveSort); - callback(strings.join(" \n")); + callback(strings.join(", ")); }); } catch(e) { // old extension manager API - take out after Firefox 3.6 support dropped @@ -395,7 +395,7 @@ getExtensionList: function(callback) { catch (e) { } } text.sort(nightly.insensitiveSort); - callback(text.join(" \n")); + callback(text.join(", ")); } }, From bfd488480d35132d5dfb1e0454a584d9eeb892d7 Mon Sep 17 00:00:00 2001 From: "Utilu.com" Date: Mon, 22 Aug 2016 11:35:47 +0200 Subject: [PATCH 3/3] Moved join to insertExtensions and copyExtensions --- extension/chrome/content/nightly.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/extension/chrome/content/nightly.js b/extension/chrome/content/nightly.js index a0c1396..bee46b7 100644 --- a/extension/chrome/content/nightly.js +++ b/extension/chrome/content/nightly.js @@ -361,7 +361,7 @@ getExtensionList: function(callback) { + (addon.userDisabled || addon.appDisabled ? " [DISABLED]" : ""); }); strings.sort(nightly.insensitiveSort); - callback(strings.join(", ")); + callback(strings); }); } catch(e) { // old extension manager API - take out after Firefox 3.6 support dropped @@ -395,7 +395,7 @@ getExtensionList: function(callback) { catch (e) { } } text.sort(nightly.insensitiveSort); - callback(text.join(", ")); + callback(text); } }, @@ -407,7 +407,7 @@ insertExtensions: function() { nightly.getExtensionList(function(text) { var newpos = element.selectionStart + text.length; var value = element.value; - element.value = value.substring(0, element.selectionStart) + text + + element.value = value.substring(0, element.selectionStart) + text.join(", ") + value.substring(element.selectionEnd); element.selectionStart = newpos; element.selectionEnd = newpos; @@ -421,7 +421,7 @@ insertExtensions: function() { copyExtensions: function() { nightly.getExtensionList(function(text) { if (text) - nightly.copyText(text); + nightly.copyText(text.join(", ")); }); },