Title setting doesn't stay

[Herb0yk]

While it's pretty cool to have it working now under all the new WE stuff, I wonder why it keeps forgetting the custom title after a new browser start, though it is still set. I have to recall the settings and reinvoke the custom title checkbox. Not a big deal however a nag when you play parallel different versions to have a destinct separation in the windows taskbar.

[UtiluMark]

Additionally, when you open a new empty tab (Ctrl+T) the custom title also doesn't get applied, at least until you've switched back and forth between tabs.

[whimboo]

Looks like a misbehavior we should fix for the 4.1 release.

[kyoshino]

Will take a look this week or next.

[UtiluMark]

@kyoshino Any progress?

[whimboo]

I actually found the knob to turn on the titlebar on MacOS (inside the customize palette). So I have also seen this behavior now after updating Firefox Nightly. Switching tabs doesn't bring back the title. But once I created a new tab the title got updated with the configured prefix.

Do we have to listen for a startup notification of Firefox to set the prefix via the WebExtension API?

[unalignedcoder]

Same problem here.

Creating a new tab then switching to an old one seems to fix it, but, funny thing: if you re-click on the about:newtab you just created, the window title switches back to "Mozilla Firefox".

Alternatively, the user needs to manually go into the nightly tester options and check/uncheck "Use custom title".

I noticed that other extensions that offer a similar functionality seem to fail in the same way.

[whimboo]

@bobsilverberg do you have an idea if that is a problem with the WebExtension API and the window title API you implemented?

[bobsilverberg]

@whimboo There is an open bug [1] about titlePreface on Windows and Linux with windows with a blank title, which sounds like at least part of the problems described above. As for having the title set when Firefox is restarted, it looks like update_titlebar is only called when windows and tabs are created and removed, so you likely also need to call it after the extension starts up, to apply the title to the existing windows. You can probably do that by calling it directly in background.js, but you'll have to check that it doesn't get called before the windows are created and have titles. You may need to play around with the timing a bit.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1387425