diff --git a/experimenter/experimenter/nimbus_ui/constants.py b/experimenter/experimenter/nimbus_ui/constants.py index 3221efc12..b0aa10a59 100644 --- a/experimenter/experimenter/nimbus_ui/constants.py +++ b/experimenter/experimenter/nimbus_ui/constants.py @@ -249,6 +249,14 @@ class NimbusUIConstants: "project_impact": """Set an impact rating so others can understand the scale of this experiment's effect.""", } + HOLDBACK_LABEL = "Is this a holdback experiment?" + HOLDBACK_HELP_TEXT = ( + "Holdback experiments continuously enroll users and run for an extended period. " + "Analysis will automatically run each week based on a 21-day observation period, " + "and an enrollment period encompassing the rest of the time between launch and " + "21 days from the run date." + ) + COENROLLMENT_NOTE = ( "Note: This feature supports co-enrollment with other experiments/rollouts " "for the selected versions." diff --git a/experimenter/experimenter/nimbus_ui/forms.py b/experimenter/experimenter/nimbus_ui/forms.py index e7d8b8eb7..e3c4a4e82 100644 --- a/experimenter/experimenter/nimbus_ui/forms.py +++ b/experimenter/experimenter/nimbus_ui/forms.py @@ -719,6 +719,9 @@ class NimbusBranchesForm(NimbusChangeLogFormMixin, forms.ModelForm): requires_restart = forms.BooleanField( required=False, widget=forms.CheckboxInput(attrs={"class": "form-check-input"}) ) + is_holdback = forms.BooleanField( + required=False, widget=forms.CheckboxInput(attrs={"class": "form-check-input"}) + ) update_on_change_fields = ( "equal_branch_ratio", @@ -744,6 +747,7 @@ class Meta: "firefox_labs_description_links", "firefox_labs_group", "requires_restart", + "is_holdback", ) widgets = { "is_rollout": forms.CheckboxInput(attrs={"class": "form-check-input"}), diff --git a/experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/edit_branches.html b/experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/edit_branches.html index deafa3ecf..aec2cbe5c 100644 --- a/experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/edit_branches.html +++ b/experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/edit_branches.html @@ -52,6 +52,17 @@
{{ NimbusUIConstants.HOLDBACK_HELP_TEXT }}
+ {% for error in form.is_holdback.errors %}