From 5066d94f4a8ec618c9f1d31f169b293feda23b5e Mon Sep 17 00:00:00 2001
From: huskcass <333684917+huskcass@users.noreply.github.com>
Date: Mon, 26 Oct 2026 02:04:18 -0700
Subject: [PATCH] fix(swiss): don't flag ScalingLimited as a scaler warning

The cluster-resources scaler card took the first condition at False as a
failure, so a healthy LLMScaler showed ScalingLimited=False
(DesiredWithinRange) as an amber badge, and its condition dot as a warning.

- scalerFailing: only AbleToScale=False or ScalingActive=False fails, with
  DecisionAvailable standing in when ScalingActive is absent (operator
  0.5.0 writes only that one)
- the scaler card badge and the standalone deploy page's scaling step use it
- the scaler card draws ScalingLimited, and DecisionAvailable when
  ScalingActive is present, with a neutral dot; other cards are unchanged

Co-authored-by: aceforeverd <11715200+aceforeverd@users.noreply.github.com>
---
 .../swiss/components/ReleaseObjects.tsx       | 29 ++++++++++++++-----
 .../components/scaler-conditions.test.ts      | 23 +++++++++++++++
 .../modules/swiss/routes/DeploymentDetail.tsx |  4 +--
 3 files changed, 46 insertions(+), 10 deletions(-)
 create mode 100644 web/src/modules/swiss/components/scaler-conditions.test.ts

diff --git a/web/src/modules/swiss/components/ReleaseObjects.tsx b/web/src/modules/swiss/components/ReleaseObjects.tsx
index 6bfa9e2..c3b2b5f 100644
--- a/web/src/modules/swiss/components/ReleaseObjects.tsx
+++ b/web/src/modules/swiss/components/ReleaseObjects.tsx
@@ -246,7 +246,7 @@ function ScalerPanel({
   );
   const current = status?.currentReplicas;
   const desired = status?.desiredReplicas;
-  const failing = status?.conditions?.find((c) => c.status === "False");
+  const failing = scalerFailing(status?.conditions);
   const custom = spec?.metricProvider === "Custom";
 
   let state: React.ReactNode = null;
@@ -349,7 +349,7 @@ function ScalerPanel({
             </div>
           )}
 
-          <Conditions conditions={status?.conditions} />
+          <Conditions conditions={status?.conditions} neutral={scalerNeutral(status?.conditions)} />
         </>
       )}
     </ObjectCard>
@@ -681,7 +681,18 @@ function Stale({
   );
 }
 
-export function Conditions({ conditions }: { conditions?: Condition[] }) {
+// Only AbleToScale=False or ScalingActive=False (DecisionAvailable on operator 0.5.0) is a scaler failure.
+export function scalerFailing(conditions?: Condition[]): Condition | undefined {
+  const of = (type: string) => conditions?.find((c) => c.type === type);
+  return [of("AbleToScale"), of("ScalingActive") ?? of("DecisionAvailable")].find((c) => c?.status === "False");
+}
+
+// ScalingLimited is informational; DecisionAvailable only mirrors ScalingActive when that is present.
+function scalerNeutral(conditions?: Condition[]): string[] {
+  return conditions?.some((c) => c.type === "ScalingActive") ? ["ScalingLimited", "DecisionAvailable"] : ["ScalingLimited"];
+}
+
+export function Conditions({ conditions, neutral = [] }: { conditions?: Condition[]; neutral?: string[] }) {
   if (!conditions?.length) return null;
   return (
     <ul className="mt-auto space-y-1.5 border-t pt-3">
@@ -691,11 +702,13 @@ export function Conditions({ conditions }: { conditions?: Condition[] }) {
             <span
               className={cn(
                 "size-1.5 shrink-0 rounded-full",
-                c.status === "True"
-                  ? "bg-success"
-                  : c.status === "False"
-                    ? "bg-warning"
-                    : "bg-muted-foreground",
+                neutral.includes(c.type)
+                  ? "bg-muted-foreground"
+                  : c.status === "True"
+                    ? "bg-success"
+                    : c.status === "False"
+                      ? "bg-warning"
+                      : "bg-muted-foreground",
               )}
             />
             <span className="font-medium">{c.type}</span>
diff --git a/web/src/modules/swiss/components/scaler-conditions.test.ts b/web/src/modules/swiss/components/scaler-conditions.test.ts
new file mode 100644
index 0000000..a9b1889
--- /dev/null
+++ b/web/src/modules/swiss/components/scaler-conditions.test.ts
@@ -0,0 +1,23 @@
+import { describe, expect, it } from "vitest";
+import { scalerFailing } from "@swiss/components/ReleaseObjects";
+
+describe("scalerFailing", () => {
+  it("does not treat ScalingLimited as a failure", () => {
+    expect(scalerFailing([
+      { type: "ScalingActive", status: "True", reason: "DecisionReceived" },
+      { type: "AbleToScale", status: "True", reason: "Synced" },
+      { type: "ScalingLimited", status: "False", reason: "DesiredWithinRange" },
+    ])).toBeUndefined();
+  });
+  it("fails on AbleToScale=False or ScalingActive=False", () => {
+    expect(scalerFailing([{ type: "AbleToScale", status: "False", reason: "TargetNotFound" }])?.reason).toBe("TargetNotFound");
+    expect(scalerFailing([{ type: "ScalingActive", status: "False", reason: "InvalidSpec" }])?.reason).toBe("InvalidSpec");
+  });
+  it("uses DecisionAvailable only when ScalingActive is absent", () => {
+    expect(scalerFailing([{ type: "DecisionAvailable", status: "False", reason: "DecisionUnavailable" }])?.reason).toBe("DecisionUnavailable");
+    expect(scalerFailing([
+      { type: "ScalingActive", status: "True", reason: "MetricsAvailable" },
+      { type: "DecisionAvailable", status: "False", reason: "DecisionUnavailable" },
+    ])).toBeUndefined();
+  });
+});
diff --git a/web/src/modules/swiss/routes/DeploymentDetail.tsx b/web/src/modules/swiss/routes/DeploymentDetail.tsx
index 23c6f9e..1fd25cc 100644
--- a/web/src/modules/swiss/routes/DeploymentDetail.tsx
+++ b/web/src/modules/swiss/routes/DeploymentDetail.tsx
@@ -32,7 +32,7 @@ import { Dialog } from "@swiss/components/ui/dialog";
 import { Field, Input } from "@swiss/components/ui/input";
 import { CatalogModelDiff } from "@swiss/components/CatalogModelDiff";
 import { Provenance } from "@swiss/components/Provenance";
-import { ReleaseObjects, pick, useReleaseObjects } from "@swiss/components/ReleaseObjects";
+import { ReleaseObjects, pick, scalerFailing, useReleaseObjects } from "@swiss/components/ReleaseObjects";
 import { AccessPoint } from "@swiss/components/Endpoint";
 import { ReleaseStatus } from "@swiss/components/ReleaseStatus";
 import { SLODialog } from "@swiss/components/SLOCard";
@@ -342,7 +342,7 @@ function scalerStep({ result, status }: ReturnType<typeof pick<LLMScalerSpec, LL
   if (!result) return { label, state: "off", detail: "fixed replicas" };
   if (result.error) return { label, state: "wait", detail: "unreadable" };
   if (result.missing) return { label, state: "bad", detail: "LLMScaler deleted" };
-  const failing = status?.conditions?.find((c) => c.status === "False");
+  const failing = scalerFailing(status?.conditions);
   if (failing) return { label, state: "bad", detail: failing.reason || failing.type };
   const cur = status?.currentReplicas;
   const want = status?.desiredReplicas;