Skip to content

Build broken on Windows 10 using CMake #1215

@programadorthi

Description

@programadorthi

return ( this->mState != 0 );

This above line I did fix changing to call: return this->mState.IsValid(); because is the same logic.

self->mGrabNextFrame = self->mFrameImage != 0;

This above line I did fix changing for the code below. I didn't know if it is correct but it works:

MOAILuaSharedPtr< int > empty;

self->mGrabNextFrame = self->mFrameImage != empty;

set (SDL2_SOURCE_DIR "${MOAI_ROOT}/3rdparty/sdl2-2.0.4")

The SDL2 third-party is using version 2.0.4 but there is 2.0.9 in submodules folder only. Changed to 2.0.9 line 5 and line 11 works.

if (( isOpenGLES == false ) && ( majorVersion < 3 )) {

This variable majorVersion is not declared in the class. I changed to sMajorVersion.

I didn't make a pull request because I don't know if these changes are correct.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions