Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

Handle unexpected return values #39

@mmmries

Description

@mmmries

I noticed that we are using a very simple case statement to enforce the behaviour of the PullConsumer which means that if a user ever implements a function that has an unexpected return value it will crash their PullConsumer without sending back a NACK or any other indication to the jetstream server.

I think this type of thing could happen pretty easily by using a with statement in user code.

This seems like something we should handle by logging an error and potentially returning a NACK to jetstream, but we probably shouldn't just crash the whole PullConsumer?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions