From 180271b1de92aeb1db592af28df86b98187f53dd Mon Sep 17 00:00:00 2001 From: "illia.prokopchuk" Date: Tue, 7 Apr 2026 11:21:06 +0300 Subject: [PATCH] Fix styles issues in federated apps --- .storybook/preview-body.html | 2 +- index.html | 4 +- src/App.jsx | 2 +- src/common/EditorModal/EditorModalView.jsx | 2 +- .../FeatureSetsPanel/FeatureSetsPanel.jsx | 2 +- .../FunctionsPanel/FunctionsPanel.jsx | 2 +- src/elements/ProjectCard/ProjectCardView.jsx | 2 +- src/layout/Page/Page.jsx | 2 +- src/utils/nuclio.remotes.utils.js | 2 +- .../common/components/dropdown.component.js | 2 +- .../page-objects/commonPagesHeader.po.js | 6 +-- .../common/page-objects/feature-store.po.js | 4 +- .../page-objects/interactive-popup.po.js | 48 +++++++++---------- .../common/page-objects/llm-prompts.po.js | 2 +- .../features/common/page-objects/models.po.js | 4 +- .../page-objects/project-settings.po.js | 2 +- .../common/page-objects/projects.po.js | 4 +- .../common/page-objects/side-panel.po.js | 2 +- 18 files changed, 47 insertions(+), 47 deletions(-) diff --git a/.storybook/preview-body.html b/.storybook/preview-body.html index 327551e3f3..6dcb2b335c 100644 --- a/.storybook/preview-body.html +++ b/.storybook/preview-body.html @@ -1 +1 @@ -
\ No newline at end of file +
\ No newline at end of file diff --git a/index.html b/index.html index 0e69003cbc..102b86d82c 100644 --- a/index.html +++ b/index.html @@ -2,14 +2,14 @@ - + MLRun
-
+
diff --git a/src/App.jsx b/src/App.jsx index a307895dab..d3db2ce35f 100644 --- a/src/App.jsx +++ b/src/App.jsx @@ -416,7 +416,7 @@ const App = () => { }> - {createPortal(, document.getElementById('overlay_container'))} + {createPortal(, document.getElementById('mlrun_overlay_container'))} ) diff --git a/src/common/EditorModal/EditorModalView.jsx b/src/common/EditorModal/EditorModalView.jsx index 8a86cacc52..855d5e4618 100644 --- a/src/common/EditorModal/EditorModalView.jsx +++ b/src/common/EditorModal/EditorModalView.jsx @@ -50,7 +50,7 @@ const EditorModalView = ({ closeModal, data, handleSaveCode, setData }) => /> , - document.getElementById('overlay_container') + document.getElementById('mlrun_overlay_container') ) EditorModalView.propTypes = { diff --git a/src/components/FeatureSetsPanel/FeatureSetsPanel.jsx b/src/components/FeatureSetsPanel/FeatureSetsPanel.jsx index b864ff6c12..d7751952cc 100644 --- a/src/components/FeatureSetsPanel/FeatureSetsPanel.jsx +++ b/src/components/FeatureSetsPanel/FeatureSetsPanel.jsx @@ -212,7 +212,7 @@ const FeatureSetsPanel = ({ closePanel, createFeatureSetSuccess, project }) => { ) }} , - document.getElementById('overlay_container') + document.getElementById('mlrun_overlay_container') ) } diff --git a/src/components/FunctionsPanel/FunctionsPanel.jsx b/src/components/FunctionsPanel/FunctionsPanel.jsx index a6de059def..2b1c9dcd55 100644 --- a/src/components/FunctionsPanel/FunctionsPanel.jsx +++ b/src/components/FunctionsPanel/FunctionsPanel.jsx @@ -341,7 +341,7 @@ const FunctionsPanel = ({ ) }} , - document.getElementById('overlay_container') + document.getElementById('mlrun_overlay_container') ) } diff --git a/src/elements/ProjectCard/ProjectCardView.jsx b/src/elements/ProjectCard/ProjectCardView.jsx index 01a51056f3..0d96494569 100644 --- a/src/elements/ProjectCard/ProjectCardView.jsx +++ b/src/elements/ProjectCard/ProjectCardView.jsx @@ -55,7 +55,7 @@ const ProjectCardView = React.forwardRef(({ actionsMenu, alert, project, statist event.target.tagName !== 'A' && !ref.current.contains(event.target) && !chipRef.current?.contains(event.target) && - !event.target.closest('#overlay_container') + !event.target.closest('#mlrun_overlay_container') ) { navigate(`/projects/${project.metadata.name}/monitor`) } diff --git a/src/layout/Page/Page.jsx b/src/layout/Page/Page.jsx index 20ba4df3f2..4fcaf215ae 100644 --- a/src/layout/Page/Page.jsx +++ b/src/layout/Page/Page.jsx @@ -113,7 +113,7 @@ const Page = () => {
{isProjectsFetched ? : }
- {createPortal(, document.getElementById('overlay_container'))} + {createPortal(, document.getElementById('mlrun_overlay_container'))} {convertedYaml.length > 0 && ( { // TODO: Automate URL resolution (Local: remove suffix | Prod: append it) if (!remoteEntryUrl.includes('/nuclio-ui')) { - // remoteEntryUrl = remoteEntryUrl.replace(/\/$/, ''); // Uncomment for Local + // remoteEntryUrl = remoteEntryUrl.replace(/\/$/, '') // Uncomment for Local remoteEntryUrl = `${remoteEntryUrl.replace(/\/$/, '')}/nuclio-ui` } diff --git a/tests/features/common/components/dropdown.component.js b/tests/features/common/components/dropdown.component.js index a74a1741b8..1ad980aee3 100644 --- a/tests/features/common/components/dropdown.component.js +++ b/tests/features/common/components/dropdown.component.js @@ -23,7 +23,7 @@ import { locatorBuilder } from '../../common-tools/common-tools' export default function(dropdownStructure) { const root = dropdownStructure.optionsInRoot ? dropdownStructure.root - : '#overlay_container' + : '#mlrun_overlay_container' const open_button = locatorBuilder`${0} ${1}` const options = locatorBuilder`${0} ${1} ${2}` const option = locatorBuilder`${0} ${1}:nth-of-type(${2}) ${3}` diff --git a/tests/features/common/page-objects/commonPagesHeader.po.js b/tests/features/common/page-objects/commonPagesHeader.po.js index 44a63cd5f1..600bc76ea9 100644 --- a/tests/features/common/page-objects/commonPagesHeader.po.js +++ b/tests/features/common/page-objects/commonPagesHeader.po.js @@ -39,10 +39,10 @@ export default { loader: By.css('.loader-wrapper .loader'), See_On_Github: By.css('header.header a[alt="MLRUN on Gihub"]'), See_On_Slack: By.css('header.header a[alt="MLRUN on Slack"]'), - Common_Hint: By.css('#overlay_container .tip'), - Common_Tolltip: By.css('#overlay_container .tooltip'), + Common_Hint: By.css('#mlrun_overlay_container .tip'), + Common_Tolltip: By.css('#mlrun_overlay_container .tooltip'), Common_Options: By.css( - '#overlay_container .options-menu .options-menu__body' + '#mlrun_overlay_container .options-menu .options-menu__body' ), MLRun_Logo: By.css('.header .header__logo'), No_Data_Message: By.css('.no-data-block h3'), diff --git a/tests/features/common/page-objects/feature-store.po.js b/tests/features/common/page-objects/feature-store.po.js index bccd4f6d1a..d95e65633b 100644 --- a/tests/features/common/page-objects/feature-store.po.js +++ b/tests/features/common/page-objects/feature-store.po.js @@ -391,7 +391,7 @@ export default { Table_Label_Filter_Input: commonLabelFilterInput, Feature_Sets_Table: commonTable(featureSetsTable), Feature_Store_Tab_Selector: featureStoreTabSelector, - Overlay: By.css('#overlay_container .chip-block-hidden_visible') + Overlay: By.css('#mlrun_overlay_container .chip-block-hidden_visible') }, featuresTab: { Feature_Store_Tab_Selector: featureStoreTabSelector, @@ -414,7 +414,7 @@ export default { Table_Tag_Filter_Dropdown: commonTableTreeFilterDropdown, Table_Refresh_Button: tableRefreshButton, Feature_Vectors_Table: commonTable(featureVectorTable), - Overlay: By.css('#overlay_container .chip-block-hidden_visible') + Overlay: By.css('#mlrun_overlay_container .chip-block-hidden_visible') }, datasets: { Delete_Artifact_Popup: By.css('[data-testid="pop-up-dialog"]'), diff --git a/tests/features/common/page-objects/interactive-popup.po.js b/tests/features/common/page-objects/interactive-popup.po.js index a9efab8840..79e67222ce 100644 --- a/tests/features/common/page-objects/interactive-popup.po.js +++ b/tests/features/common/page-objects/interactive-popup.po.js @@ -757,7 +757,7 @@ export default { Cancel_Button: commonCancelButton, Confirm_Button: By.css('.confirm-dialog__btn-container button:not(.pop-up-dialog__btn_cancel)'), Delete_Button: commonDeleteButton, - Message: By.css('#overlay_container > div > div > div:nth-child(2)') + Message: By.css('#mlrun_overlay_container > div > div > div:nth-child(2)') }, metricsSelectorPopup: { Search_Metrics_Input: inputGroup( @@ -809,8 +809,8 @@ export default { Content_Application_Log_Info: By.css('.item-info .table__item-logs:nth-of-type(1)'), Title_Function_Log_Info: By.css('.item-info > div > h3:nth-of-type(2)'), Content_Function_Log_Info: By.css('.item-info .table__item-logs:nth-of-type(2)'), - Logs_Text_container: By.css('#overlay_container .table__item .table__item-logs-content'), - Logs_Refresh_Button: By.css('#overlay_container .table__item .logs-refresh'), + Logs_Text_container: By.css('#mlrun_overlay_container .table__item .table__item-logs-content'), + Logs_Refresh_Button: By.css('#mlrun_overlay_container .table__item .logs-refresh'), Requested_Features_Table: By.css('.item-info .item-requested-features__table'), Returned_Features_Table: By.css('.item-info .details-metadata__table'), Statistics_Table: By.css('.item-info #DETAILS_STATISTICS_TABLE_ID'), @@ -843,10 +843,10 @@ export default { Category_Selector_Dropdown: categorySelect, Checkbox_Category_Selector: commonTable(checkboxCategorySelector), Overlay: By.css( - '#overlay_container .chip-block-hidden .chip-block-hidden__scrollable-container' + '#mlrun_overlay_container .chip-block-hidden .chip-block-hidden__scrollable-container' ), Hyperparameter_Checkbox: checkboxComponent({ - root: '#overlay_container .form-field-checkbox', + root: '#mlrun_overlay_container .form-field-checkbox', elements: { checkbox: 'input', name: 'label', @@ -1455,9 +1455,9 @@ export default { YAML_Modal_Container: By.css('.pop-up-dialog .yaml-modal-container pre') }, jobLogsPopup: { - Title: By.css('#overlay_container .alerts-logs .modal__content .modal__header-title'), - Cross_Cancel_Button: By.css('#overlay_container .alerts-logs .modal__header-button .data-ellipsis'), - Alerts_Logs_Container: By.css('#overlay_container .alerts-logs .modal__body .table__item-logs-container') + Title: By.css('#mlrun_overlay_container .alerts-logs .modal__content .modal__header-title'), + Cross_Cancel_Button: By.css('#mlrun_overlay_container .alerts-logs .modal__header-button .data-ellipsis'), + Alerts_Logs_Container: By.css('#mlrun_overlay_container .alerts-logs .modal__body .table__item-logs-container') }, confirmPopup: { Title: By.css('.pop-up-dialog .pop-up-dialog__header'), @@ -1657,28 +1657,28 @@ export default { Table_Project_Filter_Input: commonProjectFilterInput, Project_Name_Filter_Dropdown: dropdownComponent( generateDropdownGroup( - '#overlay_container [data-testid="pop-up-dialog"] [data-testid="project-form-field-select"]', + '#mlrun_overlay_container [data-testid="pop-up-dialog"] [data-testid="project-form-field-select"]', '.form-field__control', '.options-list [data-testid="select-option"]' ) ), Mode_Filter_Dropdown: dropdownComponent( generateDropdownGroup( - '#overlay_container [data-testid="me-mode-form-field-select"] [data-testid="select-header"]', + '#mlrun_overlay_container [data-testid="me-mode-form-field-select"] [data-testid="select-header"]', '.form-field__control', '.options-list [data-testid="select-option"]' ) ), Entity_Type_Filter_Dropdown: dropdownComponent( generateDropdownGroup( - '#overlay_container [data-testid="pop-up-dialog"] [data-testid="entity-type-form-field-select"]', + '#mlrun_overlay_container [data-testid="pop-up-dialog"] [data-testid="entity-type-form-field-select"]', '.form-field__control', '.options-list [data-testid="select-option"]' ) ), Entity_ID_Filter_Input: inputGroup( generateInputGroup( - '#overlay_container [data-testid="pop-up-dialog"] [data-testid="entity-form-field-input"]', + '#mlrun_overlay_container [data-testid="pop-up-dialog"] [data-testid="entity-form-field-input"]', true, false, true @@ -1686,7 +1686,7 @@ export default { ), Endpoint_Application_Filter_Input: inputGroup( generateInputGroup( - '#overlay_container [data-testid="pop-up-dialog"] [data-testid="endpoint-application-form-field-input"]', + '#mlrun_overlay_container [data-testid="pop-up-dialog"] [data-testid="endpoint-application-form-field-input"]', true, false, true @@ -1694,7 +1694,7 @@ export default { ), Endpoint_Result_Filter_Input: inputGroup( generateInputGroup( - '#overlay_container [data-testid="pop-up-dialog"] [data-testid="endpoint-result-form-field-input"]', + '#mlrun_overlay_container [data-testid="pop-up-dialog"] [data-testid="endpoint-result-form-field-input"]', true, false, true @@ -1702,7 +1702,7 @@ export default { ), Job_Name_Filter_Input: inputGroup( generateInputGroup( - '#overlay_container [data-testid="pop-up-dialog"] [data-testid="job-name-form-field-input"]', + '#mlrun_overlay_container [data-testid="pop-up-dialog"] [data-testid="job-name-form-field-input"]', true, false, true @@ -1710,14 +1710,14 @@ export default { ), Severity_Filter_Dropdown: dropdownComponent( generateDropdownGroup( - '#overlay_container [data-testid="pop-up-dialog"] [data-testid="severity-form-field-select"]', + '#mlrun_overlay_container [data-testid="pop-up-dialog"] [data-testid="severity-form-field-select"]', '.form-field__control', '.options-list [data-testid="select-checkbox"]' ) ), Event_Type_Filter_Dropdown: dropdownComponent( generateDropdownGroup( - '#overlay_container [data-testid="pop-up-dialog"] [data-testid="event-type-form-field-select"]', + '#mlrun_overlay_container [data-testid="pop-up-dialog"] [data-testid="event-type-form-field-select"]', '.form-field__control', '.options-list [data-testid="select-option"]' ) @@ -1763,7 +1763,7 @@ export default { ) ), Show_Iterations_Checkbox: checkboxComponent({ - root: '#overlay_container .form-field-checkbox input', + root: '#mlrun_overlay_container .form-field-checkbox input', elements: { checkbox: '', name: '', @@ -1771,7 +1771,7 @@ export default { } }), Show_Untagged: checkboxComponent({ - root: '#overlay_container .form-field-checkbox input', + root: '#mlrun_overlay_container .form-field-checkbox input', elements: { checkbox: '', name: '', @@ -1930,7 +1930,7 @@ export default { icon: '' } }), - Checkbox_Label: By.css('#overlay_container .form-field-checkbox label'), + Checkbox_Label: By.css('#mlrun_overlay_container .form-field-checkbox label'), Table_Projects_Filter_Dropdown: dropdownComponent( generateDropdownGroup( '[data-testid="project-form-field-select"] [data-testid="select-header"]', @@ -1953,12 +1953,12 @@ export default { Header_Download_Pop_Up: By.css('[data-testid="download-container"] .download-container__header') }, notificationPopUp: { - Title: By.css('#overlay_container .notification__body'), - Notification_Pop_Up: By.css('#overlay_container .notification__body'), + Title: By.css('#mlrun_overlay_container .notification__body'), + Notification_Pop_Up: By.css('#mlrun_overlay_container .notification__body'), Notification_Pop_Up_Cross_Close_Button: By.css( - '#overlay_container .notification__button-close' + '#mlrun_overlay_container .notification__button-close' ), - Retry_Button: By.css('#overlay_container .notification__body .notification__body__button-retry') + Retry_Button: By.css('#mlrun_overlay_container .notification__body .notification__body__button-retry') }, addTagPopup: { Add_Tag_Popup: By.css('[data-testid="modal"]'), diff --git a/tests/features/common/page-objects/llm-prompts.po.js b/tests/features/common/page-objects/llm-prompts.po.js index d67d66b6b9..6bd7105792 100644 --- a/tests/features/common/page-objects/llm-prompts.po.js +++ b/tests/features/common/page-objects/llm-prompts.po.js @@ -96,7 +96,7 @@ export default { Table_FilterBy_Button: By.css('[data-testid="filter-menu-btn-tooltip-wrapper"]'), Refresh_Button: By.css('[data-testid="refresh"] [data-testid="refresh-tooltip-wrapper"]'), LLMPrompts_Table: commonTable(overallTable), - Overlay: By.css('#overlay_container .chip-block-hidden_visible'), + Overlay: By.css('#mlrun_overlay_container .chip-block-hidden_visible'), History_Back_Button: By.css('.history-back-link .history-back-link__icon'), Version_History_Title: By.css( '.history-back-link .history-back-link__title [data-testid="version-history"]' diff --git a/tests/features/common/page-objects/models.po.js b/tests/features/common/page-objects/models.po.js index e640be63d1..dad4ae2c2d 100644 --- a/tests/features/common/page-objects/models.po.js +++ b/tests/features/common/page-objects/models.po.js @@ -268,7 +268,7 @@ export default { '.content__action-bar-wrapper .action-bar__actions [data-testid="refresh"]' ), Models_Table: commonTable(modelsTable), - Overlay: By.css('#overlay_container .chip-block-hidden_visible'), + Overlay: By.css('#mlrun_overlay_container .chip-block-hidden_visible'), Register_Model_Button: By.css('.content__action-bar-wrapper .action-bar__actions .btn-tertiary'), Train_Model_Button: By.css('.content__action-bar-wrapper .action-bar__actions .btn-primary'), Table_FilterBy_Button: By.css('.models .action-bar [data-testid="filter-menu-btn"]'), @@ -283,7 +283,7 @@ export default { modelEndpoints: { Table_Refresh_Button: tableRefreshButton, Model_Endpoints_Table: commonTable(modelsEndpointTable), - Overlay: By.css('#overlay_container .chip-block-hidden_visible'), + Overlay: By.css('#mlrun_overlay_container .chip-block-hidden_visible'), Table_FilterBy_Button: By.css('[data-testid="filter-menu-btn-tooltip-wrapper"]'), Column_Name_Header: By.css('[data-testid="name"]'), Sort_By_Name: By.css('[data-testid="name"].sortable-header-cell_active svg'), diff --git a/tests/features/common/page-objects/project-settings.po.js b/tests/features/common/page-objects/project-settings.po.js index 87fb7ade51..6634acd90d 100644 --- a/tests/features/common/page-objects/project-settings.po.js +++ b/tests/features/common/page-objects/project-settings.po.js @@ -199,6 +199,6 @@ export default { Secrets_Table: commonTable(secretsTable), Add_Secret_Button: By.css('[data-testid="secrets-add-btn"]'), Secrets_Hint: By.css('.settings__card-subtitle'), - Error_Message: By.css('#overlay_container .notification__body') + Error_Message: By.css('#mlrun_overlay_container .notification__body') } } diff --git a/tests/features/common/page-objects/projects.po.js b/tests/features/common/page-objects/projects.po.js index 7d1782c2fa..18871f88ac 100644 --- a/tests/features/common/page-objects/projects.po.js +++ b/tests/features/common/page-objects/projects.po.js @@ -92,7 +92,7 @@ const ProjectsTableSelector = { root: '.project-card__actions-menu', menuElements: { open_button: 'button', - options: '#overlay_container .actions-menu__option' + options: '#mlrun_overlay_container .actions-menu__option' } } } @@ -125,7 +125,7 @@ export default { Refresh_Projects_Button: By.css('.projects-content-header .data-ellipsis button'), Projects_Table: commonTable(ProjectsTableSelector), Project_Card_Alert_Icon: By.css('.project-card__header-title .project-card__alert'), - Overlay: By.css('#overlay_container .chip-block-hidden_visible'), + Overlay: By.css('#mlrun_overlay_container .chip-block-hidden_visible'), Active_Projects_Button: By.css( '.projects__wrapper .projects-content-header .projects-content-header-item [data-testid="active"]' ), diff --git a/tests/features/common/page-objects/side-panel.po.js b/tests/features/common/page-objects/side-panel.po.js index 37f485fbf8..5db1951613 100644 --- a/tests/features/common/page-objects/side-panel.po.js +++ b/tests/features/common/page-objects/side-panel.po.js @@ -767,7 +767,7 @@ export default { '.feature-set-panel .panel-title .checkbox' ), Passthrough_PopUp_Dialog:{ - Dialog_PopUp: By.css('#overlay_container .pop-up-dialog'), + Dialog_PopUp: By.css('#mlrun_overlay_container .pop-up-dialog'), Close_Button: By.css('.pop-up-dialog .pop-up-dialog__header .pop-up-dialog__btn_close'), Dialog_Message: By.css('.pop-up-dialog .confirm-dialog__message'), Keep_Online_Target_Set_Button: By.css('.pop-up-dialog .confirm-dialog__btn-container .btn-tertiary'),