From 3dc2a2b3f06b91489787bb9285e709f252679098 Mon Sep 17 00:00:00 2001 From: Muhamed Isabegovic Date: Wed, 14 Oct 2026 11:00:25 +0200 Subject: [PATCH 1/2] Lint templates with Herb and move to the latest RuboCop - RuboCop 1.82.1 to 1.92.0; the codebase stays clean. - Herb 0.11 (`@herb-tools/linter`, pinned) replaces erb_lint and better_html. It reads HTML and ERB as one document, so it also checks HTML validity and accessibility. CI sets up Node 22 and runs `npm run lint:erb`; bin/ci runs it as "Style: ERB". - .herb.yml lints app/ for the Action View framework and fails on errors. Five rules are off, each with its reason in the file: two false positives, the href="#" links Stimulus fills in, `tag.attributes` and `checked` toggles, and the collection-render style rule. - The first run's real errors are fixed: the radius options toggle `selected` through control flow, the cookie banner's diff --git a/app/views/users/sessions/new.html.erb b/app/views/users/sessions/new.html.erb index 7bb4ad5c..8d2c84c5 100644 --- a/app/views/users/sessions/new.html.erb +++ b/app/views/users/sessions/new.html.erb @@ -20,7 +20,7 @@
<%= render "users/flash" %> - <%= form_with scope: resource_name, url: user_session_path, local: true, class: "space-y-6", data: { controller: "local-data" } do |f| %> + <%= form_with scope: resource_name, url: user_session_path, local: true, class: "space-y-6", data: { controller: "local-data" } do %> <%# Email %>