LPBaseException names

[awichmann-mintel]

@alphachai @chavlin @greatheights82 @ ekelsey have agreed that the exceptions FailCatastrophically and FailButContinue are not descriptive almost to the point of being misnomers. I propose FailCatastrophically => FailButRetry and FailButContinue => FailAndDropMessage yet other's may oppose them; that is the goal of this issue.

[charlieparkes]

FailAndDrop makes sense, but FailButRetry needs some thought, because it won't necessarily retry, right? 🤔

[charlieparkes]

We could also go more explicitly along the lines of

• FailNoRaise
• FailWillRaise

[awichmann-mintel]

I agree, FailButRetry may not be accurate.
Those two describe what will happen, but they don't explain the consequences as well.

[charlieparkes]

I see where you're coming from, but we should also consider that these exception names should make sense for all EventSource types. Retry is only true on SQS. I'd be happy with the middle ground that at least makes them describe what is happening, then refactor the readme to make the implications clearer for each event source type

[awichmann-mintel]

(can I reply via email?!) yeah I like that idea. I think including a section with a primer on SQS visibility before explaining the implications would help newer users a lot.

…

On Thu, Aug 20, 2020 at 10:33 AM Charlie ***@***.***> wrote: I see where you're coming from, but we should also consider that these exception names should make sense for all EventSource types. Retry is only true on SQS. I'd be happy with the middle ground that at least makes them describe *what* is happening, then refactor the readme to make the implications clearer for each event source type — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALAIAZSFZGBVXQYS2R54F6LSBU633ANCNFSM4QGGSSLA> .

-- Mintel Group Limited | 333 West Wacker Drive Suite 1100 | Chicago, Illinois USA 60606 Contact details for our other offices can be found at http://www.mintel.com/office-locations <http://www.mintel.com/office-locations>. This email and any attachments may include content that is confidential, privileged or otherwise protected under applicable law. Unauthorized disclosure, copying, distribution or use of the contents is prohibited and may be unlawful. If you have received this email in error, including without appropriate authorization, then please reply to the sender about the error and delete this email and any attachments.

[awichmann-mintel]

re: (can I reply via email?!)

I can. That's pretty cool