Clean Up Signs

[mide]

Ideas:

• Allow filter to match case insensitive (-- RENDER -- or -- render -- or -- Render -- all match) Will not implement per Refactor Sign Rendering #63
• Strip empty lines from displaying (maybe only from edges, not between lines) Remove Sign Padding #68
• Code cleanup, maybe some kind of map and filter to process the signs? Refactor Sign Rendering #63
• Figure out how to horizontally center sign test within render.
• Figure out how to break the sign filter code into multiple functions (see Remove Sign Padding #68)

[mide]

Case insensitive and filters done in #63

[mide]

Per discussions in #63, we won't have case insensitive.

[magneticflux-]

Also to consider: centering the signs' text and preserving blank lines in the sign. For centering theoretically you could add <br /> <center> as the joiner, but that's not HTML5 😞. I don't know what to do about blank lines. Maybe just remove them if they're empty after a .strip()?

This is what signs currently look like on my map:

Additionally, if there are blank lines at the beginning of the sign, they appear in the text. Blank lines at the end of the sign don't, so all signs that are vertically centered in-game look top-heavy in the render.

[mide]

Yeah, this needs some work for sure. In the meantime you can switch back to the previous behavior and use a space " " as the joiner.

I agree 💯 with you though, and I hope to fix this.

[mide]

@magneticflux- I propose #68 to deal with the spacing (the signs being top heavy)

[mide]

Figure out how to break the sign filter code into multiple functions (see #68)

Given the upstream project is no longer maintained, and there is an open issue for this, I will mark this task as complete, as wontfix.