Skip to content

Expired feedback links should be removed from query tips #4009

@jikuja

Description

@jikuja

Describe the bug
Multiple links on query tips are expired

To Reproduce

echo '| URL | Expired | Location |'
echo '|-----|---------|----------|'
grep -oE 'https?://[^[:space:]"'\''<>]+' src/app/views/sidebar/sample-queries/queries.ts \
| sort | uniq | grep 'https://aka.ms/' \
| while read -r url; do
    loc=$(curl -sI "$url" | awk -F': ' 'tolower($1)=="location"{print $2}' | tr -d '\r')
    if echo "$loc" | grep -q 'https://www.bing.com'; then
      expired=true
    else
      expired=false
    fi
    printf '| %s | %s | %s |\n' "$url" "$expired" "$loc"
  done
URL Expired Location
https://aka.ms/aadmgs true https://www.bing.com?ref=aka&shorturl=aadmgs
https://aka.ms/applicationsAPISurvey true https://www.bing.com?ref=aka&shorturl=applicationsAPISurvey
https://aka.ms/appRoleAssignmentAPISurvey true https://www.bing.com?ref=aka&shorturl=appRoleAssignmentAPISurvey
https://aka.ms/appTemplateAPISurvey false https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR_yN8EPoGo5OpR1hgmCp1XxURUFMUjc1OUc5REdWQk40QkFGTFhQN1dTMC4u
https://aka.ms/caapifeedback false https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR_yN8EPoGo5OpR1hgmCp1XxUQlc3Q0w5VlJOS09aWVQ4SVFMMVFTR0cxNi4u
https://aka.ms/claimsMappingPolicyAPISurvey true https://www.bing.com?ref=aka&shorturl=claimsMappingPolicyAPISurvey
https://aka.ms/deviceAPIFeedback false https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fforms.office.com%2FPages%2FResponsePage.aspx%3Fid%3Dv4j5cvGGr0GRqy180BHbR_yN8EPoGo5OpR1hgmCp1XxUNFVTQjI3SUlCM1BaNDdWNlZaWUxYNUxLMC4u&data=04%7C01%7CHannah.Fowler%40microsoft.com%7C6e8afa660cc7475a25a208d89560e1c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C637423590619458179%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=BW9XPSxmRpwlHFppP0wJ5MJB49qLp94Mkgd7lzq89fE%3D&reserved=0
https://aka.ms/GroupsAPIFeedback false https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR_yN8EPoGo5OpR1hgmCp1XxUMDZSVFdIWkU5M1JCWEVPMzRRTVA5NUw3Ti4u
https://aka.ms/GroupsAPIFeedback. true https://www.bing.com?ref=aka&shorturl=GroupsAPIFeedback.
https://aka.ms/IdentityProtectionAPIFeedback true https://www.bing.com?ref=aka&shorturl=IdentityProtectionAPIFeedback
https://aka.ms/mmkv1b false https://teams.microsoft.com/l/meetup-join/19%3ameeting_NjlhYTY1ZTItZGZkZC00OTk5LWEwNmQtZGEwZGEzZWI0YTc0%40thread.skype/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%22798ab99c-b38e-43b1-8610-bcb84a0c0809%22%7d
https://aka.ms/msgraphaadsurveyconnectorgroups false https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR_yN8EPoGo5OpR1hgmCp1XxURE5KNjZCMEhYRkEyWEFBVUhCV0ZVTjE2My4u
https://aka.ms/msgraphaadsurveyconnectors false https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR_yN8EPoGo5OpR1hgmCp1XxUMzkySDdPVk8wQ0RHVkxTS0ZVRTI3VExGRC4u
https://aka.ms/projectRomeSamples/ false https://github.com/Microsoft/project-rome/
https://aka.ms/servicePrincipalAPISurvey true https://www.bing.com?ref=aka&shorturl=servicePrincipalAPISurvey
https://aka.ms/UsersAPIFeedback false https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR_yN8EPoGo5OpR1hgmCp1XxURVRQQ0k4VVJPUUEyWlZYOU5INTFSSFRaVi4u
https://aka.ms/UsersAPIFeedback. true https://www.bing.com?ref=aka&shorturl=UsersAPIFeedback.
https://aka.ms/ybuw2i true https://www.bing.com?ref=aka&shorturl=ybuw2i

All the entries with aka.ms returning location header with https://www.bing.com are expired or the shortlink has been removed

Expected behavior
There should not ne any expired links. Further testing should include checking status of the linked forms.

Notes

https://aka.ms/GroupsAPIFeedback and https://aka.ms/GroupsAPIFeedback. are not duplicate entries. On my browser e.g. browser includes dot on as a tag href.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions