Skip to content

Consider restoring Interface::is_com_interface #4252

@tim-weis

Description

@tim-weis

Suggestion

#4230 introduced several useful simplifications. One of them, I feel, went a bit over the edge, namely:

Inline trivial wrapperInterface::is_com_interface was a single-line wrapper around cursor.has_pure_virtual_methods(); both call-sites are inlined and the method removed.

The update kept the semantics unchanged, but dropped two pieces of information along the way:

  • the function name
  • the doc comment explaining that it implements a heuristic and what that heuristic (currently) is

This isn't anything major, though, as a human, I found the previous version with a function easier to comprehend. I can draft a PR that restores the function (and call sites) if you share the sentiment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions