Skip to content

Commit d59560d

Browse files
committed
test: remove package manager tests from refactor
Package manager coverage is being developed separately in PR #1704. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b2fe9b5-38ea-442f-b07a-b6c71134d480
1 parent 0a8c3ad commit d59560d

7 files changed

Lines changed: 8 additions & 627 deletions

File tree

.github/instructions/testing-workflow.instructions.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,4 +606,3 @@ envConfig.inspect
606606
- **Never skip tests to hide infrastructure problems**: If tests require native binaries (like `pet`), the CI workflow must build/download them. Skipping tests when infrastructure is missing gives false confidence. Build from source (like vscode-python does) rather than skipping. Tests should fail clearly when something is wrong (2)
607607
- **No retries for masking flakiness**: Mocha `retries` should not be used to mask test flakiness. If a test is flaky, fix the root cause. Retries hide real issues and slow down CI (1)
608608
- **pet binary is required for environment manager registration**: The smoke/E2E/integration tests require the `pet` binary from `microsoft/python-environment-tools` to be built and placed in `python-env-tools/bin/`. Without it, `waitForApiReady()` will timeout because managers never register. CI must build pet from source using `cargo build --release --package pet` (2)
609-
- **Package lifecycle integration tests require package-index network access**: Venv quick creation seeds Pip through `uv`, and package roundtrip tests download packages. TLS or connectivity failures to PyPI can make `createEnvironment()` return `undefined` before package assertions run (1)

src/managers/builtin/venvUtils.ts

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import { getWorkspacePersistentState } from '../../common/persistentState';
1919
import { EventNames } from '../../common/telemetry/constants';
2020
import { sendTelemetryEvent } from '../../common/telemetry/sender';
2121
import { normalizePath } from '../../common/utils/pathUtils';
22-
import { isTestExecution } from '../../common/utils/testing';
2322
import { getVenvPythonPath } from '../../common/utils/virtualEnvironment';
2423
import {
2524
showErrorMessage,
@@ -569,16 +568,14 @@ export async function removeVenv(environment: PythonEnvironment, log: LogOutputC
569568
// Normalize path for UI display - ensure forward slashes on Windows
570569
const displayPath = normalizePath(envPath);
571570

572-
const confirm = isTestExecution()
573-
? { title: Common.yes }
574-
: await showWarningMessage(
575-
l10n.t('Are you sure you want to remove {0}?', displayPath),
576-
{
577-
modal: true,
578-
},
579-
{ title: Common.yes },
580-
{ title: Common.no, isCloseAffordance: true },
581-
);
571+
const confirm = await showWarningMessage(
572+
l10n.t('Are you sure you want to remove {0}?', displayPath),
573+
{
574+
modal: true,
575+
},
576+
{ title: Common.yes },
577+
{ title: Common.no, isCloseAffordance: true },
578+
);
582579
if (confirm?.title === Common.yes) {
583580
const result = await withProgress(
584581
{

src/test/integration/packageManagerRoundtrip.integration.test.ts

Lines changed: 0 additions & 252 deletions
This file was deleted.

0 commit comments

Comments
 (0)