Skip to content

Commit c6abcf8

Browse files
committed
address feedback
1 parent 351e729 commit c6abcf8

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

‎src/managers/builtin/inlineScript/envManager.ts‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -229,13 +229,13 @@ export class InlineScriptEnvManager implements EnvironmentManager, Disposable {
229229
}),
230230
);
231231
let candidates = derivedChecks
232-
.filter((candidate) => !candidate.derived)
233-
.map((candidate) => candidate.environment)
234232
.filter(
235233
(candidate) =>
236-
!metadata.requiresPython ||
237-
this.matchesInstallConstraint(metadata.requiresPython, candidate.version),
238-
);
234+
!candidate.derived &&
235+
(!metadata.requiresPython ||
236+
this.matchesInstallConstraint(metadata.requiresPython, candidate.environment.version)),
237+
)
238+
.map((candidate) => candidate.environment);
239239

240240
while (candidates.length > 0) {
241241
const environment = pickCompatibleInterpreter(candidates, undefined);
@@ -266,6 +266,8 @@ export class InlineScriptEnvManager implements EnvironmentManager, Disposable {
266266
const run = this.baseInterpreterInstallationQueue.then(() =>
267267
this.installAndSelectBaseInterpreterSerially(metadata),
268268
);
269+
// Keep the stored queue tail fulfilled so one failed request does not block later attempts;
270+
// the caller still observes the original result through `run`.
269271
this.baseInterpreterInstallationQueue = run.then(
270272
() => undefined,
271273
() => undefined,

0 commit comments

Comments
 (0)