Use PythonVersion version when getting latest python version

Author: edvilme

src/managers/common/utils.ts

@@ -4,6 +4,7 @@ import path from 'path';
 import { commands, ConfigurationTarget, l10n, window, workspace } from 'vscode';
 import { PythonCommandRunConfiguration, PythonEnvironment, PythonEnvironmentApi } from '../../api';
 import { traceLog, traceVerbose } from '../../common/logging';
+import { PythonVersion } from '../../common/pythonVersion';
 import { isWindows } from '../../common/utils/platformUtils';
 import { ShellConstants } from '../../features/common/shellConstants';
 import { getDefaultEnvManagerSetting, setDefaultEnvManagerBroken } from '../../features/settings/settingHelpers';
@@ -68,9 +69,12 @@ export function getLatest(collection: PythonEnvironment[]): PythonEnvironment |
     const candidates = nonErroredEnvs.length > 0 ? nonErroredEnvs : collection;
 
     let latest = candidates[0];
+    let latestVersion: PythonVersion | undefined;
     for (const env of candidates) {
-        if (pep440Valid(env.version) && pep440Valid(latest.version) && pep440Compare(env.version, latest.version) > 0) {
+        const version = PythonVersion.tryParse(env.version);
+        if (version && (!latestVersion || version.compareTo(latestVersion) > 0)) {
             latest = env;
+            latestVersion = version;
         }
     }
     return latest;

src/test/managers/common/utils.getLatest.unit.test.ts

@@ -0,0 +1,36 @@
+import assert from 'node:assert';
+import path from 'node:path';
+import { getLatest } from '../../../managers/common/utils';
+import { createMockPythonEnvironment } from '../../mocks/pythonEnvironment';
+
+suite('getLatest', () => {
+    test('selects the latest normalized Python version', () => {
+        const systemPython = createMockPythonEnvironment({
+            envPath: path.join('usr', 'bin', 'python3'),
+            version: '3.9.6.final.0',
+        });
+        const homebrewPython = createMockPythonEnvironment({
+            envPath: path.join('opt', 'homebrew', 'bin', 'python3'),
+            version: '3.14.3.final.0',
+        });
+
+        assert.strictEqual(getLatest([systemPython, homebrewPython]), homebrewPython);
+    });
+
+    test('prefers a comparable version when the first version is invalid', () => {
+        const invalid = createMockPythonEnvironment({ envPath: path.join('invalid', 'python'), version: 'unknown' });
+        const valid = createMockPythonEnvironment({ envPath: path.join('valid', 'python'), version: '3.14.3' });
+
+        assert.strictEqual(getLatest([invalid, valid]), valid);
+    });
+
+    test('excludes errored environments when a usable environment exists', () => {
+        const older = createMockPythonEnvironment({ envPath: path.join('older', 'python'), version: '3.9.6' });
+        const errored = {
+            ...createMockPythonEnvironment({ envPath: path.join('errored', 'python'), version: '3.14.3' }),
+            error: 'Broken interpreter',
+        };
+
+        assert.strictEqual(getLatest([older, errored]), older);
+    });
+});