Skip to content

Commit 58f231d

Browse files
Fix macOS test launch with VS Code 1.131 (#1684)
### Why VS Code 1.131 removed the legacy `Contents/MacOS/Electron` compatibility path from its macOS application bundle. `@vscode/test-electron` 2.5.2 still launches that hard-coded path, so all macOS smoke jobs fail with `ENOENT` before VS Code or the extension starts. This currently blocks the macOS checks on #1656. The upstream issue and fix are microsoft/vscode-test#349 and microsoft/vscode-test#350. ### What Upgrade `@vscode/test-electron` from 2.5.2 to 3.1.0 and refresh the lockfile. Version 3.1.0 resolves the macOS executable from `CFBundleExecutable` in `Info.plist`, with the old `Electron` path retained as a fallback for older VS Code builds. This is a development-only dependency change. Version 3.1.0 requires Node 22, which is already used by CI. ### Validation - `npm run compile-tests` - `npm run unittest` — 1469 passing, 0 failing, 5 pending Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 39dcc6a3-0fbd-4f36-9d0f-68677de49c27
1 parent 64db682 commit 58f231d

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

package-lock.json

Lines changed: 9 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,7 @@
723723
"@types/which": "^3.0.4",
724724
"@typescript-eslint/eslint-plugin": "^8.16.0",
725725
"@typescript-eslint/parser": "^8.16.0",
726-
"@vscode/test-electron": "^2.5.2",
726+
"@vscode/test-electron": "^3.1.0",
727727
"@vscode/vsce": "^3.9.2",
728728
"eslint": "^9.15.0",
729729
"glob": "^8.1.0",

0 commit comments

Comments
 (0)