Extract Windows device-name check and rename script template

Move the Windows reserved-device-name test out of the script filename
validator and into a shared isWindowsReservedDeviceName helper in
common/utils/pathUtils, so the rule lives with the other path utilities
and can be reused. newScriptProject now calls the helper and no longer
imports isWindows directly. Add focused unit coverage for the helper.

Rename the internal template folder new723ScriptTemplate to
newInlineScriptTemplate and update all creator and test references. Only
the folder name changes; the template content and the user-facing
creator, class, and command are untouched.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1487b95c-ac14-455f-9b7f-9770cf65e11e

Author: StellaHuang95

…templates/new723ScriptTemplate/script.py …plates/newInlineScriptTemplate/script.pyfiles/templates/new723ScriptTemplate/script.py renamed to files/templates/newInlineScriptTemplate/script.py files/templates/new723ScriptTemplate/script.py renamed to files/templates/newInlineScriptTemplate/script.py

@@ -87,6 +87,22 @@ export function isSameOrParentPath(parentPath: string, candidatePath: string): b
     );
 }
 
+/**
+ * Determines whether `value` maps to a reserved Windows device name (e.g. `CON`,
+ * `PRN`, `AUX`, `NUL`, `COM1`-`COM9`, `LPT1`-`LPT9`).
+ *
+ * The check inspects the portion of the name before the first dot, since Windows
+ * disallows these names regardless of extension, and only reports `true` on
+ * Windows, where the restriction applies.
+ *
+ * @param value The base file name (without directory) to test.
+ * @returns `true` on Windows when `value` resolves to a reserved device name.
+ */
+export function isWindowsReservedDeviceName(value: string): boolean {
+    const deviceBaseName = value.split('.')[0];
+    return isWindows() && /^(con|prn|aux|nul|com[1-9]|lpt[1-9])$/i.test(deviceBaseName);
+}
+
 export function getResourceUri(resourcePath: string, root?: string): Uri | undefined {
     try {
         if (!resourcePath) {

src/common/utils/pathUtils.ts

@@ -4,8 +4,7 @@ import { commands, l10n, MarkdownString, QuickInputButtons, Uri, window, Workspa
 import { PythonProject, PythonProjectCreator, PythonProjectCreatorOptions } from '../../api';
 import { NEW_PROJECT_TEMPLATES_FOLDER } from '../../common/constants';
 import { traceError } from '../../common/logging';
-import { isSameOrParentPath } from '../../common/utils/pathUtils';
-import { isWindows } from '../../common/utils/platformUtils';
+import { isSameOrParentPath, isWindowsReservedDeviceName } from '../../common/utils/pathUtils';
 import { showErrorMessage, showInputBoxWithButtons, showTextDocument } from '../../common/window.apis';
 import { getWorkspaceFolder, getWorkspaceFolders } from '../../common/workspace.apis';
 import { PythonProjectManager } from '../../internal.api';
@@ -20,8 +19,7 @@ function validateScriptFileName(value: string): string | null {
         return l10n.t('Script name must end with ".py".');
     }
     const baseName = value.replace(/\.py$/, '');
-    const deviceBaseName = baseName.split('.')[0];
-    if (isWindows() && /^(con|prn|aux|nul|com[1-9]|lpt[1-9])$/i.test(deviceBaseName)) {
+    if (isWindowsReservedDeviceName(baseName)) {
         return l10n.t('Script name uses a reserved Windows device name.');
     }
     // following PyPI (PEP 508) rules for package names
@@ -97,7 +95,7 @@ export class NewScriptProject implements PythonProjectCreator {
         }
 
         // 1. Copy template file
-        const newScriptTemplateFile = path.join(NEW_PROJECT_TEMPLATES_FOLDER, 'new723ScriptTemplate', 'script.py');
+        const newScriptTemplateFile = path.join(NEW_PROJECT_TEMPLATES_FOLDER, 'newInlineScriptTemplate', 'script.py');
         if (!(await fs.pathExists(newScriptTemplateFile))) {
             window.showErrorMessage(l10n.t('Template file does not exist, aborting creation.'));
             traceError(`Template file not found at: ${newScriptTemplateFile}`);

src/features/creators/newScriptProject.ts

@@ -1,7 +1,7 @@
 import assert from 'node:assert';
 import * as sinon from 'sinon';
 import { Uri } from 'vscode';
-import { getResourceUri, normalizePath } from '../../common/utils/pathUtils';
+import { getResourceUri, isWindowsReservedDeviceName, normalizePath } from '../../common/utils/pathUtils';
 import * as utils from '../../common/utils/platformUtils';
 
 suite('Path Utilities', () => {
@@ -128,4 +128,40 @@ suite('Path Utilities', () => {
             assert.strictEqual(result, 'C:/Path/To/File.txt');
         });
     });
+
+    suite('isWindowsReservedDeviceName', () => {
+        let isWindowsStub: sinon.SinonStub;
+
+        setup(() => {
+            isWindowsStub = sinon.stub(utils, 'isWindows');
+        });
+
+        teardown(() => {
+            sinon.restore();
+        });
+
+        test('flags reserved device names on Windows regardless of extension', () => {
+            isWindowsStub.returns(true);
+
+            for (const name of ['CON', 'prn', 'aux', 'nul', 'com1', 'LPT9', 'con.py', 'nul.foo']) {
+                assert.strictEqual(isWindowsReservedDeviceName(name), true, `${name} should be reserved`);
+            }
+        });
+
+        test('allows names that only resemble reserved device names on Windows', () => {
+            isWindowsStub.returns(true);
+
+            for (const name of ['console', 'com10', 'lpt0', 'printer', 'aux_helper']) {
+                assert.strictEqual(isWindowsReservedDeviceName(name), false, `${name} should be allowed`);
+            }
+        });
+
+        test('never flags reserved device names off Windows', () => {
+            isWindowsStub.returns(false);
+
+            for (const name of ['CON', 'nul', 'com1', 'lpt9']) {
+                assert.strictEqual(isWindowsReservedDeviceName(name), false, `${name} should be allowed off Windows`);
+            }
+        });
+    });
 });

src/test/common/pathUtils.unit.test.ts

@@ -28,7 +28,7 @@ const TEMPLATE_PATH = path.join(
     '..',
     'files',
     'templates',
-    'new723ScriptTemplate',
+    'newInlineScriptTemplate',
     'script.py',
 );
 
@@ -40,7 +40,7 @@ function asRemoteUri(fsPath: string, authority = 'ssh-remote+test-host'): Uri {
     });
 }
 
-suite('new723ScriptTemplate / NewScriptProject', () => {
+suite('newInlineScriptTemplate / NewScriptProject', () => {
     let tmpDir: string;
     let getWorkspaceFolderStub: sinon.SinonStub;
     let getWorkspaceFoldersStub: sinon.SinonStub;
@@ -64,7 +64,7 @@ suite('new723ScriptTemplate / NewScriptProject', () => {
 
     function stubSuccessfulFileCreation() {
         const templateFile = path.resolve(
-            path.join(NEW_PROJECT_TEMPLATES_FOLDER, 'new723ScriptTemplate', 'script.py'),
+            path.join(NEW_PROJECT_TEMPLATES_FOLDER, 'newInlineScriptTemplate', 'script.py'),
         );
         const showTextDocumentStub = sinon
             .stub(windowApis, 'showTextDocument')
@@ -250,7 +250,7 @@ suite('new723ScriptTemplate / NewScriptProject', () => {
         const scriptDestination = path.resolve(rootUri.fsPath, scriptFileName);
         const expectedTemplatePath = path.join(
             NEW_PROJECT_TEMPLATES_FOLDER,
-            'new723ScriptTemplate',
+            'newInlineScriptTemplate',
             'script.py',
         );
         const addStub = sinon.stub().resolves();