Skip to content

Viewer does not handle embedded file content properly #17

@harleenkohli

Description

@harleenkohli

We have a sarif file which has file content embedded. When viewed in the web viewer (using scans tab), the file link in points to this location:

https://sariftools.gallerycdn.vsassets.io/extensions/sariftools/sarif-viewer-build-tab/0.2.130/1576196245030/

Expected:

  • If possible to view this in some way, the actual file content (that can be extracted from the sarif file) should be viewable.

  • If it is not possible, we should remove the hyperlink from the scans tab file name.

image

Here is example of one such case:
https://secretscantest.visualstudio.com/SecDevOps/_build/results?buildId=1317&view=sariftools.sarif-viewer-build-tab.sariftools.sarif-viewer-build-tab

The associated sarif ifle can be downloaded from here:
https://secretscantest.visualstudio.com/SecDevOps/_build/results?buildId=1317&view=artifacts&type=publishedArtifacts

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions