From 857ce4064785c13343c372a6cfe0b84f0ee16ee7 Mon Sep 17 00:00:00 2001 From: Dan Legg Date: Thu, 8 Oct 2026 15:18:37 -0700 Subject: [PATCH] Fix IsolationSession bundle BinSkim failure Remove node-pty PDBs from the staged test bundle so BinSkim does not consume upstream S_COMPILE3 records. Runtime binaries remain intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d43372e-f942-4bb7-a358-48f9218c2332 --- .../IsolationSession.TestBundle.Build.Job.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml b/.azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml index a8d1c3675..e3b123323 100644 --- a/.azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml +++ b/.azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml @@ -332,6 +332,21 @@ jobs: Copy-Item "$sdkRoot/LICENSE.md" "$sdkStaged/LICENSE.md" } Copy-Item -Recurse "$sdkRoot/node_modules" "$sdkStaged/node_modules" + + # node-pty ships third-party PDBs beside its prebuilt binaries. BinSkim + # reads their S_COMPILE3 records and reports BA2007 for upstream compiler + # switches, as it does for co-located Rust CRT PDBs. The symbols are not + # required to execute this test-only bundle, so keep the runtime binaries + # intact and omit only node-pty's PDBs. + $nodePtyPdbs = @( + Get-ChildItem -Path $sdkInteg -Filter '*.pdb' -Recurse -File | + Where-Object { $_.FullName -match '[\\/]node-pty[\\/]' } + ) + foreach ($pdb in $nodePtyPdbs) { + Remove-Item -LiteralPath $pdb.FullName -Force -ErrorAction Stop + } + Write-Host " -> removed $($nodePtyPdbs.Count) node-pty PDB(s) from the test bundle" + Write-Host " -> sdk-integration/ (Node E2E suite)" # Manifest