From b5d90ad80d6d6f9c5996c807e989531355877880 Mon Sep 17 00:00:00 2001 From: Elizabeth Craig Date: Fri, 20 Mar 2026 13:04:20 -0700 Subject: [PATCH] Separate PR build for basic checks --- .github/workflows/basic-checks.yml | 42 ++++++++++++++++++++++++++++++ .github/workflows/pr.yml | 20 -------------- 2 files changed, 42 insertions(+), 20 deletions(-) create mode 100644 .github/workflows/basic-checks.yml diff --git a/.github/workflows/basic-checks.yml b/.github/workflows/basic-checks.yml new file mode 100644 index 000000000..7bb840311 --- /dev/null +++ b/.github/workflows/basic-checks.yml @@ -0,0 +1,42 @@ +name: Check change files, formatting, deps + +on: + pull_request: + branches: [master, v1] + push: + branches: [master, v1] + +concurrency: + # For PRs, use the ref (branch) in the concurrency group so that new pushes cancel any old runs. + # For pushes to master, ideally we wouldn't set a concurrency group, but github actions doesn't + # support conditional blocks of settings, so we use the SHA so the "group" is unique. + group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/master' && github.sha || github.ref }} + cancel-in-progress: true + +permissions: {} + +jobs: + basic-checks: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 + + - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6 + with: + node-version-file: .nvmrc + + - run: yarn --immutable + + - name: Code Format Check + run: yarn format:check + + - name: Check Change Files + run: yarn checkchange + + # @see https://www.npmjs.com/package/syncpack + - name: Check consistent package.json dep versions + run: yarn syncpack:check + + - name: Dependency checks + run: yarn deps:check diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index c1295e562..dcd7b6e6b 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -1,6 +1,3 @@ -# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node -# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions - name: PR on: @@ -40,23 +37,6 @@ jobs: - run: yarn --immutable - - name: Code Format Check - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} - run: yarn format:check - - - name: Check Change Files - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} - run: yarn checkchange - - # @see https://www.npmjs.com/package/syncpack - - name: Check consistent package.json dep versions - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} - run: yarn syncpack:check - - - name: Dependency checks - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '22.x' }} - run: yarn deps:check - - name: Build, Test, Lint run: yarn ci --concurrency 2 --verbose env: