From 81bb9bd46e35270c1a87a72303da50859df71249 Mon Sep 17 00:00:00 2001 From: peterstone2017 <12449837+YunchuWang@users.noreply.github.com> Date: Mon, 28 Apr 2025 17:29:52 -0700 Subject: [PATCH 1/2] Improve logging for unexpected connection failures in DurableTaskGrpcWorker --- .../java/com/microsoft/durabletask/DurableTaskGrpcWorker.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java b/client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java index 89f87a9f..2c4b472d 100644 --- a/client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java +++ b/client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java @@ -191,7 +191,7 @@ else if (requestType == RequestCase.HEALTHPING) } else if (e.getStatus().getCode() == Status.Code.CANCELLED) { logger.log(Level.INFO, "Durable Task worker has disconnected from {0}.", this.getSidecarAddress()); } else { - logger.log(Level.WARNING, "Unexpected failure connecting to {0}.", this.getSidecarAddress()); + logger.log(Level.WARNING, String.format("Unexpected failure connecting to %s", this.getSidecarAddress()), e); } // Retry after 5 seconds From 1a5db269262bf50e7275053f03d17dc3092561e0 Mon Sep 17 00:00:00 2001 From: peterstone2017 <12449837+YunchuWang@users.noreply.github.com> Date: Mon, 28 Apr 2025 17:32:41 -0700 Subject: [PATCH 2/2] Update CHANGELOG.md to include improvements in logging for connection failures in DurableTaskGrpcWorker --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c89bd94c..2d5cac2b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,5 @@ ## placeholder +* Improve logging for unexpected connection failures in DurableTaskGrpcWorker ([#216](https://github.com/microsoft/durabletask-java/pull/216/files)) * Add User-Agent Header to gRPC Metadata ([#213](https://github.com/microsoft/durabletask-java/pull/213)) ## v1.5.0-preview.1 * Update protobuf definitions to include new properties in OrchestratorRequest and update source commit hash ([#214](https://github.com/microsoft/durabletask-java/pull/214))