Skip to content

[Bug?] Issues about the dataloader and dataset. #25

@AlexsaseXie

Description

@AlexsaseXie

I read the code in this repo and found some questions about the dataloader part. It seems that the code of dataloder is heavily brought from the GRNet repo while the author seems to change some behaviour of the dataloader.

Q1: The validation set of the ShapeNet is never used, while the test set is used during training
https://github.com/microsoft/SpareNet/blob/main/datasets/data_loaders.py#L49

val_data_loader = torch.utils.data.DataLoader(
            dataset=test_dataset_loader.get_dataset(DatasetSubset.TEST),
            batch_size=1,
            num_workers=cfg.CONST.num_workers,
            collate_fn=collate_fn,
            pin_memory=True,
            shuffle=False,
        )

Q2: Only the last view of point cloud is used during training when training on ShapeNet with GRNet version.
https://github.com/microsoft/SpareNet/blob/main/datasets/data_loaders.py#L148

Dataset(
            {
                "required_items": ["partial_cloud", "gtcloud"],
                "shuffle": subset == DatasetSubset.TRAIN,
            },
            file_list,
            transforms,
        )

The n_renderings param is never set so the rand_idx in Dataset.getitem is always -1 which refer to the last view of point cloud.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions