Skip to content

Compatibility with Preact #135

@Inve1951

Description

@Inve1951

Preact calls render with arguments. This is an iconic feature which allows destructuring props, state, and context in the parameter list. Currently ReSub breaks that pattern when Options.preventTryCatchInRender is falsy (which is the default).

Restoring compatibility should be as easy as forwarding the arguments list here.

Apparently I also have to manually set Options.development in order to get the TypeError thrown from destructuring undefined since my pipeline replaces the literal process.env.NODE_ENV at build time whereas you carefully test it for existence. I'll give that a shot tomorrow.

As a result my Components just rendered nothing and my coffee got cold.

Can we have this fixed?
If you want a PR it will have to wait till after the holidays.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions