Fix _validate_guid to catch TypeError for None/int GUID inputs

Author: Abel Milash

src/PowerPlatform/Dataverse/operations/records.py

@@ -21,10 +21,19 @@
 
 
 def _validate_guid(record_id: str, param_name: str = "record_id") -> None:
-    """Raise ValueError if *record_id* is not a valid GUID."""
+    """Raise ValueError if *record_id* is not a valid GUID.
+
+    Catches all non-GUID inputs uniformly:
+      * ``ValueError``     -- malformed hex string (``uuid.UUID("not-a-guid")``)
+      * ``AttributeError`` -- input lacks ``replace``/``encode`` (rare)
+      * ``TypeError``      -- non-string input such as ``None`` or ``int``
+        (``uuid.UUID(None)`` / ``uuid.UUID(123)``).  Without this, callers
+        would see the raw constructor message ``"one of the hex, bytes, ...
+        arguments must be given"`` instead of the helpful message below.
+    """
     try:
         uuid.UUID(record_id)
-    except (ValueError, AttributeError):
+    except (ValueError, AttributeError, TypeError):
         raise ValueError(
             f"{param_name} {record_id!r} is not a valid GUID "
             f"(expected 8-4-4-4-12 hex, e.g. 'a1b2c3d4-1234-5678-9abc-def012345678'). "

tests/unit/test_records_operations.py

@@ -202,6 +202,20 @@ def test_valid_guid_accepted(self):
         result = self.client.records.retrieve("account", "a1b2c3d4-1234-5678-9abc-def012345678")
         self.assertIsNotNone(result)
 
+    def test_retrieve_none_record_id_raises_value_error(self):
+        """retrieve(None) surfaces the friendly ValueError, not the raw uuid TypeError."""
+        with self.assertRaises(ValueError) as ctx:
+            self.client.records.retrieve("account", None)
+        self.assertIn("not a valid GUID", str(ctx.exception))
+        self.client._odata._get.assert_not_called()
+
+    def test_retrieve_int_record_id_raises_value_error(self):
+        """retrieve(<int>) surfaces the friendly ValueError, not the raw uuid TypeError."""
+        with self.assertRaises(ValueError) as ctx:
+            self.client.records.retrieve("account", 12345)
+        self.assertIn("not a valid GUID", str(ctx.exception))
+        self.client._odata._get.assert_not_called()
+
     # --------------------------------------------------------------------- get
 
     def test_get_single(self):