Updates to Python Feature Management (#64)

* dependency update + strict

* removing setup py usage

* Create copilot-instructions.md

* formatting

* test and sample headers

* pr comments

* Update copilot-instructions.md

* pr comments

Author: mrm9084

.github/copilot-instructions.md

@@ -0,0 +1,121 @@
+# FEATURE MANAGEMENT FOR PYTHON - COPILOT INSTRUCTIONS
+
+---
+
+## CORE PRINCIPLES
+
+### RULE 1: DO NOT REPEAT INSTRUCTIONS
+**NEVER repeat instructions when guiding users. Users should follow instructions independently.**
+
+### RULE 2: REFERENCE OFFICIAL DOCUMENTATION
+**ALWAYS** reference the [Azure SDK Python Design Guidelines](https://azure.github.io/azure-sdk/python_design.html)
+- Link to specific pages when answering guidelines questions
+- Use this as the authoritative source for SDK development guidance
+
+### RULE 3: VERIFY ENVIRONMENT FIRST
+**REQUIRED CONDITIONS:**
+- Always activate the Python virtual environment before running Python commands:
+  - On Windows: `.venv\Scripts\activate`
+  - On Linux/macOS: `source .venv/bin/activate`
+- Use `python -m pip` instead of bare `pip` when installing packages.
+
+---
+
+## DEV SETUP
+
+Install all dependencies with:
+
+```bash
+python -m pip install -e ".[dev,test]"
+```
+
+This project requires **Python 3.10 or newer**.
+
+---
+
+## PROJECT STRUCTURE
+
+- `featuremanagement/` — Synchronous feature management code
+- `featuremanagement/aio/` — Async equivalents of feature management classes
+- `featuremanagement/_models/` — Data models (feature flags, variants, telemetry)
+- `featuremanagement/_time_window_filter/` — Time window filter with recurrence support
+- `featuremanagement/azuremonitor/` — Optional Azure Monitor telemetry integration
+- `tests/` — Unit tests (sync and async)
+- `samples/` — Sample applications
+
+---
+
+## CODE CONVENTIONS
+
+- All source files must include the Microsoft copyright header.
+- All modules must have a module-level docstring.
+- Maximum line length is 120 characters.
+- Use type annotations on all functions and methods.
+
+---
+
+## PYLINT OPERATIONS
+
+### RUNNING PYLINT
+
+**COMMAND:**
+```bash
+pylint featuremanagement
+```
+
+### FIXING PYLINT WARNINGS
+
+**ALLOWED ACTIONS:**
+- ✅ Fix warnings with 100% confidence
+- ✅ Use existing files for all solutions
+- ✅ Reference official guidelines
+
+**FORBIDDEN ACTIONS:**
+- ❌ Fix warnings without complete confidence
+- ❌ Create new files for solutions
+- ❌ Import non-existent modules
+- ❌ Add new dependencies/imports
+- ❌ Make unnecessary large changes
+- ❌ Change code style without reason
+- ❌ Delete code without clear justification
+
+---
+
+## MYPY OPERATIONS
+
+### RUNNING MYPY
+
+**COMMAND:**
+```bash
+mypy featuremanagement
+```
+
+The project uses `strict = True` in `mypy.ini`.
+
+---
+
+## CODE FORMATTING
+
+### RUNNING BLACK
+
+**COMMAND:**
+```bash
+black featuremanagement
+```
+
+Line length is configured to 120 in `pyproject.toml`.
+
+---
+
+## TESTING
+
+### RUNNING TESTS
+
+**COMMAND:**
+```bash
+pytest tests
+```
+
+- Sync tests are in `tests/test_*.py`
+- Async tests use `pytest-asyncio` and are in files ending with `_async.py`
+- Run tests with: `pytest tests`

.github/workflows/validate.yml

@@ -17,8 +17,7 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        pip install -r dev_requirements.txt
-        pip install .
+        python -m pip install ".[dev]"
     - name: Analysing the code with pylint
       run: |
         pylint featuremanagement
@@ -30,9 +29,9 @@ jobs:
       uses: streetsidesoftware/cspell-action@v6.8.0
     - name: Test with pytest
       run: |
-        pip install -r tests/requirements.txt
+        python -m pip install ".[test]"
         pytest tests --doctest-modules --cov-report=xml --cov-report=html
     - name: Analysing the samples with pylint
       run: |
-        pip install -r samples/requirements.txt
+        python -m pip install -r samples/requirements.txt
         pylint --disable=missing-function-docstring,missing-class-docstring samples tests

MANIFEST.in

@@ -12,7 +12,7 @@ ignorePaths:
   - '.*'
   - 'build'
   - 'docs'
-  - 'dev_requirements.txt'
+  - 'node_modules'
   - '*.egg-info'
   - '*.ini'
   - '*.toml'

cspell.config.yaml

@@ -3,6 +3,8 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
+"""Feature management library for Python."""
+
 from ._featuremanager import FeatureManager
 from ._featurefilters import FeatureFilter
 from ._defaultfilters import TimeWindowFilter, TargetingFilter

dev_requirements.txt

@@ -3,6 +3,8 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
+"""Built-in feature filter implementations."""
+
 import logging
 import hashlib
 from datetime import datetime, timezone

featuremanagement/__init__.py

@@ -3,6 +3,8 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
+"""Base class for feature filters."""
+
 from abc import ABC, abstractmethod
 from typing import Mapping, Callable, Any, Optional
 

featuremanagement/_defaultfilters.py

@@ -3,6 +3,8 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
+"""Synchronous feature manager implementation."""
+
 import logging
 from typing import cast, overload, Any, Optional, Dict, Mapping, List, Tuple
 from ._defaultfilters import TimeWindowFilter, TargetingFilter

featuremanagement/_featurefilters.py

@@ -3,6 +3,8 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
+"""Base class for feature manager implementations."""
+
 import hashlib
 import logging
 from abc import ABC