`repo.json` inconsistently decoded (JSON5 vs JSON)

[usfbih8u]

Description

When repo.json is decoded, the plugin installer uses JSON5, but the plugin manager uses JSON for configuration.

References:

micro/internal/config/plugin_manager.go

Line 38 in 5dabe17

dec := json.NewDecoder(bytes.NewReader(data))

micro/internal/config/plugin_installer.go

Line 158 in 5dabe17

decoder := json5.NewDecoder(resp.Body)

If you use a comment in repo.json, the plugin won't be loaded but can be installed.

I assume JSON5 should be used in both(?).

Environment

• Version: 2.0.15
• OS: It does not matter.
• Terminal: It does not matter.

[JoeKar]

Indeed, on the reader/decoder side this is somewhat inconsistent.
We still have other locations where we use the standard json from Go itself, but it is used for the encoding short before the file write.

I agree, that we should change it in the plugin_manager.go from encoding/json to github.com/micro-editor/json5 and use json5 instead of json.