Skip to content

[Code Review: new-features] Fan label missing from DEFAULT_REGISTRY.labelIds #278

@mholzi

Description

@mholzi

File: custom_components/dashview/frontend/stores/registry-store.js (lines 65-80 vs 25-39)

Severity: medium

LABEL_PATTERNS includes fan patterns (fan, ventilator, lüfter) but DEFAULT_REGISTRY.labelIds does not include a fan key. The resolved ID is stored in an undeclared property, which could cause issues with strict object checking or documentation.

Suggestion: Add fan: null to DEFAULT_REGISTRY.labelIds to match the LABEL_PATTERNS entry.

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-reviewAutomated code review findingnew-featuresCode review: new-features

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions