From 1a2f8552df4e0849df1a8203afa80ecda6955559 Mon Sep 17 00:00:00 2001 From: Michael Blauberg <103556269+mblauberg@users.noreply.github.com> Date: Wed, 4 Nov 2026 16:37:30 +1000 Subject: [PATCH] Fix export validation of freshly read config bytes --- Sources/PureMouseAppSupport/ConfigTransfer.swift | 5 +++++ .../ConfigTransferTests.swift | 12 ++++++++++++ 2 files changed, 17 insertions(+) diff --git a/Sources/PureMouseAppSupport/ConfigTransfer.swift b/Sources/PureMouseAppSupport/ConfigTransfer.swift index 158a670..e3a5500 100644 --- a/Sources/PureMouseAppSupport/ConfigTransfer.swift +++ b/Sources/PureMouseAppSupport/ConfigTransfer.swift @@ -100,6 +100,11 @@ extension ConfigStore { } else { data = ConfigTree().data() } + do { + try ConfigCheck.validate(data) + } catch { + return "The config file has an error, so it wasn't exported: \(ConfigCheck.message(for: error))" + } do { try data.write(to: url, options: .atomic) return nil diff --git a/Tests/PureMouseAppSupportTests/ConfigTransferTests.swift b/Tests/PureMouseAppSupportTests/ConfigTransferTests.swift index b2fd334..965e651 100644 --- a/Tests/PureMouseAppSupportTests/ConfigTransferTests.swift +++ b/Tests/PureMouseAppSupportTests/ConfigTransferTests.swift @@ -61,6 +61,18 @@ struct ConfigTransferTests { #expect(!sandbox.exists(other)) } + @Test func exportRefusesInvalidBytesWrittenSinceTheLastLoad() throws { + try sandbox.write(#"{"dpi": 800}"#) + let store = loadedStore() + #expect(store.configError == nil) + + try sandbox.write(#"{"dpi": 999999}"#) + let target = sandbox.directory.appending(path: "copy.json") + #expect(store.exportSettings(to: target) + == "The config file has an error, so it wasn't exported: dpi must be 50–25600, not 999999") + #expect(!sandbox.exists(target)) + } + @Test func exportReportsAnUnwritableTarget() throws { try sandbox.write("{}") let problem = loadedStore().exportSettings(to: sandbox.directory.appending(path: "missing/dir/copy.json"))