From eedd03c6a122da81aab02f13e8cf105fd314e30e Mon Sep 17 00:00:00 2001 From: Michael Blauberg <103556269+mblauberg@users.noreply.github.com> Date: Wed, 4 Nov 2026 16:31:14 +1000 Subject: [PATCH] Clamp system double-click interval before integer conversion --- Sources/PureMouseKit/Config.swift | 3 ++- Tests/PureMouseKitTests/TriggerTableTests.swift | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Sources/PureMouseKit/Config.swift b/Sources/PureMouseKit/Config.swift index f96ac9d..cd47d50 100644 --- a/Sources/PureMouseKit/Config.swift +++ b/Sources/PureMouseKit/Config.swift @@ -549,7 +549,8 @@ public struct Config: Decodable, Sendable { if let configured { return configured } let seconds = systemSeconds.flatMap { $0 > 0 && $0.isFinite ? $0 : nil } ?? 0.5 let range = doubleClickMsRange - return min(max(Int((seconds * 1000).rounded()), range.lowerBound), range.upperBound) + let milliseconds = min(max(seconds * 1000, Double(range.lowerBound)), Double(range.upperBound)) + return Int(milliseconds.rounded()) } public static var defaultURL: URL { diff --git a/Tests/PureMouseKitTests/TriggerTableTests.swift b/Tests/PureMouseKitTests/TriggerTableTests.swift index de6afd7..89db19c 100644 --- a/Tests/PureMouseKitTests/TriggerTableTests.swift +++ b/Tests/PureMouseKitTests/TriggerTableTests.swift @@ -119,8 +119,13 @@ import Testing #expect(fresh.doubleClickInterval(systemSeconds: nil) == 500) #expect(fresh.doubleClickInterval(systemSeconds: 0.3) == 300) #expect(fresh.doubleClickInterval(systemSeconds: 5) == 1000) + #expect(fresh.doubleClickInterval(systemSeconds: 1e20) == Config.doubleClickMsRange.upperBound) + #expect(fresh.doubleClickInterval(systemSeconds: Double.greatestFiniteMagnitude) == Config.doubleClickMsRange.upperBound) #expect(fresh.doubleClickInterval(systemSeconds: 0.05) == 150) #expect(fresh.doubleClickInterval(systemSeconds: -1) == 500) + #expect(fresh.doubleClickInterval(systemSeconds: .infinity) == 500) + #expect(fresh.doubleClickInterval(systemSeconds: .nan) == 500) + #expect(fresh.doubleClickInterval(systemSeconds: 0.3005) == 301) #expect(try decode(#"{"doubleClickMs": 250}"#).doubleClickInterval(systemSeconds: 0.8) == 250) }